[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#607731: lintian: Improving test coverage



Package: lintian
Version: 2.4.3
Severity: wishlist
Tags: patch

Hi

Adding tests for these tags:
 debian-rules-not-a-makefile
 wish-script-but-no-wish-dep
 ruby-script-but-no-ruby-dep
 gawk-script-but-no-gawk-dep
 mawk-script-but-no-mawk-dep
 tclsh-script-but-no-tclsh-dep


~Niels
From fc2b57a06006276e63a88df62839e6eb1a7f1859 Mon Sep 17 00:00:00 2001
From: Niels Thykier <niels@thykier.net>
Date: Tue, 21 Dec 2010 14:42:33 +0100
Subject: [PATCH] Added some tests to improve coverage.

---
 t/tests/rules-not-makefile/debian/debian/rules     |   11 +++++++++++
 t/tests/rules-not-makefile/desc                    |    6 ++++++
 t/tests/rules-not-makefile/tags                    |    1 +
 t/tests/scripts-missing-dep/debian/debian/clean    |    1 +
 t/tests/scripts-missing-dep/debian/debian/install  |    1 +
 t/tests/scripts-missing-dep/debian/debian/manpages |    1 +
 t/tests/scripts-missing-dep/debian/debian/rules    |   12 ++++++++++++
 t/tests/scripts-missing-dep/debian/gawk-script     |    3 +++
 t/tests/scripts-missing-dep/debian/mawk-script     |    3 +++
 t/tests/scripts-missing-dep/debian/ruby-script     |    3 +++
 t/tests/scripts-missing-dep/debian/script.pod      |   18 ++++++++++++++++++
 t/tests/scripts-missing-dep/debian/tclsh-script    |    3 +++
 t/tests/scripts-missing-dep/debian/wish-script     |    3 +++
 t/tests/scripts-missing-dep/desc                   |    9 +++++++++
 t/tests/scripts-missing-dep/tags                   |    5 +++++
 15 files changed, 80 insertions(+), 0 deletions(-)
 create mode 100755 t/tests/rules-not-makefile/debian/debian/rules
 create mode 100644 t/tests/rules-not-makefile/desc
 create mode 100644 t/tests/rules-not-makefile/tags
 create mode 100644 t/tests/scripts-missing-dep/debian/debian/clean
 create mode 100644 t/tests/scripts-missing-dep/debian/debian/install
 create mode 100644 t/tests/scripts-missing-dep/debian/debian/manpages
 create mode 100755 t/tests/scripts-missing-dep/debian/debian/rules
 create mode 100755 t/tests/scripts-missing-dep/debian/gawk-script
 create mode 100755 t/tests/scripts-missing-dep/debian/mawk-script
 create mode 100755 t/tests/scripts-missing-dep/debian/ruby-script
 create mode 100644 t/tests/scripts-missing-dep/debian/script.pod
 create mode 100755 t/tests/scripts-missing-dep/debian/tclsh-script
 create mode 100755 t/tests/scripts-missing-dep/debian/wish-script
 create mode 100644 t/tests/scripts-missing-dep/desc
 create mode 100644 t/tests/scripts-missing-dep/tags

diff --git a/t/tests/rules-not-makefile/debian/debian/rules b/t/tests/rules-not-makefile/debian/debian/rules
new file mode 100755
index 0000000..d3a1c6c
--- /dev/null
+++ b/t/tests/rules-not-makefile/debian/debian/rules
@@ -0,0 +1,11 @@
+#!/bin/sh
+# This should be a makefile.
+exec dh "$@"
+
+# fake targets to trick lintain into believing the 
+# required targets are present (removed unrelated errors).
+binary:
+binary-arch:
+binary-indep:
+build:
+clean:
diff --git a/t/tests/rules-not-makefile/desc b/t/tests/rules-not-makefile/desc
new file mode 100644
index 0000000..e01a928
--- /dev/null
+++ b/t/tests/rules-not-makefile/desc
@@ -0,0 +1,6 @@
+Testname: rules-not-makefile
+Sequence: 6000
+Version: 1.0
+Description: Check if the rules file is a makefile
+Test-For: debian-rules-not-a-makefile
+
diff --git a/t/tests/rules-not-makefile/tags b/t/tests/rules-not-makefile/tags
new file mode 100644
index 0000000..017b643
--- /dev/null
+++ b/t/tests/rules-not-makefile/tags
@@ -0,0 +1 @@
+E: rules-not-makefile source: debian-rules-not-a-makefile
diff --git a/t/tests/scripts-missing-dep/debian/debian/clean b/t/tests/scripts-missing-dep/debian/debian/clean
new file mode 100644
index 0000000..8f76e67
--- /dev/null
+++ b/t/tests/scripts-missing-dep/debian/debian/clean
@@ -0,0 +1 @@
+man/
diff --git a/t/tests/scripts-missing-dep/debian/debian/install b/t/tests/scripts-missing-dep/debian/debian/install
new file mode 100644
index 0000000..0486c9a
--- /dev/null
+++ b/t/tests/scripts-missing-dep/debian/debian/install
@@ -0,0 +1 @@
+*-script usr/bin/
diff --git a/t/tests/scripts-missing-dep/debian/debian/manpages b/t/tests/scripts-missing-dep/debian/debian/manpages
new file mode 100644
index 0000000..bf519d7
--- /dev/null
+++ b/t/tests/scripts-missing-dep/debian/debian/manpages
@@ -0,0 +1 @@
+man/*.1
diff --git a/t/tests/scripts-missing-dep/debian/debian/rules b/t/tests/scripts-missing-dep/debian/debian/rules
new file mode 100755
index 0000000..654f90a
--- /dev/null
+++ b/t/tests/scripts-missing-dep/debian/debian/rules
@@ -0,0 +1,12 @@
+#!/usr/bin/make -f
+
+%:
+	dh $@
+
+override_dh_auto_build:
+	mkdir man
+	for FILE in *-script ; do \
+		sed s/@SCRIPT@/$$FILE/g script.pod | \
+			pod2man --section=1 > man/$$FILE.1 ; \
+	done
+
diff --git a/t/tests/scripts-missing-dep/debian/gawk-script b/t/tests/scripts-missing-dep/debian/gawk-script
new file mode 100755
index 0000000..b66729e
--- /dev/null
+++ b/t/tests/scripts-missing-dep/debian/gawk-script
@@ -0,0 +1,3 @@
+#!/usr/bin/gawk -f
+
+# do something.
diff --git a/t/tests/scripts-missing-dep/debian/mawk-script b/t/tests/scripts-missing-dep/debian/mawk-script
new file mode 100755
index 0000000..fbb3316
--- /dev/null
+++ b/t/tests/scripts-missing-dep/debian/mawk-script
@@ -0,0 +1,3 @@
+#!/usr/bin/mawk -f
+
+# do something.
diff --git a/t/tests/scripts-missing-dep/debian/ruby-script b/t/tests/scripts-missing-dep/debian/ruby-script
new file mode 100755
index 0000000..4700685
--- /dev/null
+++ b/t/tests/scripts-missing-dep/debian/ruby-script
@@ -0,0 +1,3 @@
+#!/usr/bin/ruby
+
+# do something.
diff --git a/t/tests/scripts-missing-dep/debian/script.pod b/t/tests/scripts-missing-dep/debian/script.pod
new file mode 100644
index 0000000..8ffa2d0
--- /dev/null
+++ b/t/tests/scripts-missing-dep/debian/script.pod
@@ -0,0 +1,18 @@
+=head1 NAME
+
+@SCRIPT@ - Cool script to do stuff written in some script language.
+
+=head1 SYNOPSIS
+
+@SCRIPT@ --cool-argument
+
+=head1 DESCRIPTION
+
+This script is very awesome and does something you do not even know
+you need.
+
+=head1 AUTHOR
+
+I made this
+
+
diff --git a/t/tests/scripts-missing-dep/debian/tclsh-script b/t/tests/scripts-missing-dep/debian/tclsh-script
new file mode 100755
index 0000000..2e6707a
--- /dev/null
+++ b/t/tests/scripts-missing-dep/debian/tclsh-script
@@ -0,0 +1,3 @@
+#!/usr/bin/tclsh
+
+# do something.
diff --git a/t/tests/scripts-missing-dep/debian/wish-script b/t/tests/scripts-missing-dep/debian/wish-script
new file mode 100755
index 0000000..5a2cd12
--- /dev/null
+++ b/t/tests/scripts-missing-dep/debian/wish-script
@@ -0,0 +1,3 @@
+#!/usr/bin/wish
+
+# do something.
diff --git a/t/tests/scripts-missing-dep/desc b/t/tests/scripts-missing-dep/desc
new file mode 100644
index 0000000..d6794cb
--- /dev/null
+++ b/t/tests/scripts-missing-dep/desc
@@ -0,0 +1,9 @@
+Testname: scripts-missing-dep
+Sequence: 6000
+Version: 1.0
+Description: Check missing dep on various script interpreters
+Test-For: wish-script-but-no-wish-dep
+ ruby-script-but-no-ruby-dep
+ gawk-script-but-no-gawk-dep
+ mawk-script-but-no-mawk-dep
+ tclsh-script-but-no-tclsh-dep
diff --git a/t/tests/scripts-missing-dep/tags b/t/tests/scripts-missing-dep/tags
new file mode 100644
index 0000000..9299f1e
--- /dev/null
+++ b/t/tests/scripts-missing-dep/tags
@@ -0,0 +1,5 @@
+E: scripts-missing-dep: gawk-script-but-no-gawk-dep ./usr/bin/gawk-script
+E: scripts-missing-dep: mawk-script-but-no-mawk-dep ./usr/bin/mawk-script
+E: scripts-missing-dep: ruby-script-but-no-ruby-dep ./usr/bin/ruby-script
+E: scripts-missing-dep: tclsh-script-but-no-tclsh-dep ./usr/bin/tclsh-script
+E: scripts-missing-dep: wish-script-but-no-wish-dep ./usr/bin/wish-script
-- 
1.7.2.3


Reply to: