[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#573839: lintian: [checks/cruft] [PATCH] improve native-package-with-dash-version



Package: lintian
Version: 2.3.3
Severity: minor
Tags: patch


Typical situation:

    $ debian -us -uc

    ...
    W: package source: native-package-with-dash-version

The description of the warning:

    $ echo W: package source: native-package-with-dash-version | lintian-info

    W: package source: native-package-with-dash-version
    N:
    N:   Native packaging should only be used if a piece of software was
    N:   written specifically to be turned into a Debian package. In this case,
    N:   the version number should not contain a Debian revision part.
    N:   
    N:   Native source packages are sometimes created by accident. In most
    N:   cases the reason is the location of the original source tarball.
    N:   dpkg-source searches for this in
    N:   ../package_upstream-version.orig.tar.gz.
    N:   
    N:   Severity: normal, Certainty: certain
    N:

The attached patch suggests to check explicitly debian/chnagelog's
VERSION, and in addition, adds a line to suggest checking possibly
incorrectly set:

   $ cat debian/source/format
   3.0 (native)

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-trunk-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils               2.20.1-2          The GNU assembler, linker and bina
ii  diffstat               1.47-1            produces graph of changes introduc
ii  dpkg-dev               1.15.5.6          Debian package development tools
ii  file                   5.04-1            Determines file type using "magic"
ii  gettext                0.17-9            GNU Internationalization utilities
ii  intltool-debian        0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii  libapt-pkg-perl        0.1.24            Perl interface to libapt-pkg
ii  libclass-accessor-perl 0.34-1            Perl module that automatically gen
ii  libipc-run-perl        0.84-1            Perl module for running processes
ii  libparse-debianchangel 1.1.1-2           parse Debian changelogs and output
ii  libtimedate-perl       1.2000-1          collection of modules to manipulat
ii  liburi-perl            1.52-1            module to manipulate and access UR
ii  locales                2.10.2-6          Embedded GNU C Library: National L
ii  man-db                 2.5.7-1           on-line manual pager
ii  perl [libdigest-sha-pe 5.10.1-11         Larry Wall's Practical Extraction 

lintian recommends no packages.

Versions of packages lintian suggests:
pn  binutils-multiarch            <none>     (no description available)
ii  libtext-template-perl         1.45-1     Text::Template perl module
ii  man-db                        2.5.7-1    on-line manual pager

-- no debconf information
>From 8a32cbb41f672489214290fcd83eaa989dd86e82 Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aalto@cante.net>
Date: Tue, 2 Mar 2010 23:55:16 +0200
Subject: [PATCH] checks/cruft.desc: improve native-package-with-dash-version

Signed-off-by: Jari Aalto <jari.aalto@cante.net>
---
 checks/cruft.desc |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/checks/cruft.desc b/checks/cruft.desc
index 4d42a2b..f5ac35e 100644
--- a/checks/cruft.desc
+++ b/checks/cruft.desc
@@ -14,7 +14,8 @@ Info: Native packaging should only be used if a piece of software was
  .
  Native source packages are sometimes created by accident. In most cases
  the reason is the location of the original source tarball. dpkg-source
- searches for this in ../package_upstream-version.orig.tar.gz.
+ searches debian/changelog's VERSION in ../package_VERSION.orig.tar.gz.
+ Check also mistakenly set '(native)' value in file debian/source/format.
 
 Tag: non-native-package-with-native-version
 Severity: normal
-- 
1.7.0


Reply to: