[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.3.2-26-gf6d6500



The following commit has been merged in the master branch:
commit 0e53d65947aaaebb4aeb506258f3abb3b87251e7
Author: Raphael Geissert <atomo64@gmail.com>
Date:   Sun Jan 31 01:13:51 2010 -0600

    Warn about packages containing update-desktop-database cache files
    
    * checks/files{,.desc}:
      + [RG] Warn about packages shipping mimeinfo.cache files, generated by
        update-desktop-database.  Thanks, Raphaël Hertzog.  (Closes: #567753)

diff --git a/checks/files b/checks/files
index fbf6fe2..cb1171b 100644
--- a/checks/files
+++ b/checks/files
@@ -420,6 +420,10 @@ foreach my $file (sort keys %{$info->index}) {
 		tag "file-in-usr-local", "$file";
 	    }
 	}
+	# ---------------- /usr/share/applications
+	elsif ($file =~ m,^usr/share/applications/mimeinfo.cache(?:\.gz)?$,) {
+	    tag 'package-contains-mimeinfo.cache-file', $file;
+	}
 	# ---------------- /usr/share/man and /usr/X11R6/man
 	elsif ($file =~ m,^usr/X11R6/man/\S+, or $file =~ m,^usr/share/man/\S+,) {
 	    if ($type eq 'udeb') {
diff --git a/checks/files.desc b/checks/files.desc
index b20373c..634268f 100644
--- a/checks/files.desc
+++ b/checks/files.desc
@@ -1055,6 +1055,17 @@ Info: This package contains a cache file generated automatically by
  to be generated dynamically based on the installed MIME-Info Database
  files on the system.
 
+Tag: package-contains-mimeinfo.cache-file
+Severity: serious
+Certainty: certain
+Info: This package contains a file named <tt>mimeinfo.cache</tt>,
+ possibly compressed, in <tt>/usr/share/applications</tt>.  This file is
+ generated automatically by update-desktop-database when a package
+ containing <tt>.desktop</tt> files associated to MIME types is installed.
+ Some upstream build systems create it automatically, but it must not be
+ included in a package since it needs to be generated dynamically based on
+ the installed .desktop files on the system.
+
 Tag: package-modifies-ld.so-search-path
 Severity: important
 Certainty: possible
diff --git a/debian/changelog b/debian/changelog
index 4d19459..07bb832 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -5,6 +5,7 @@ lintian (2.3.3) UNRELEASED; urgency=low
       - missing-dependency-on-phpapi
       - obsolete-comments-style-in-php-ini
       - package-contains-mime-cache-file
+      - package-contains-mimeinfo.cache-file
       - triplet-dir-and-architecture-mismatch
 
   * checks/binaries{,.desc}:
@@ -27,6 +28,8 @@ lintian (2.3.3) UNRELEASED; urgency=low
       architecture of the package, per Policy 3.8.4 requirement.
     + [RG] Warn about packages shipping cache files generated by
       update-mime-database.  Thanks, Jakub Wilk.  (Closes: #563685)
+    + [RG] Warn about packages shipping mimeinfo.cache files, generated by
+      update-desktop-database.  Thanks, Raphaël Hertzog.  (Closes: #567753)
   * checks/init.d:
     + [RG] Warn about init scripts depending on checkroot instead of
       $local_fs.
diff --git a/t/tests/files-general/debian/debian/install b/t/tests/files-general/debian/debian/install
index d099884..dabd5b3 100644
--- a/t/tests/files-general/debian/debian/install
+++ b/t/tests/files-general/debian/debian/install
@@ -9,3 +9,4 @@ foo.vcproj usr/lib/foo
 lintian-lib.conf etc/ld.so.conf.d
 php-foo.ini etc/php5/conf.d
 types usr/share/mime
+mimeinfo.cache usr/share/applications
diff --git a/t/tests/files-general/debian/mimeinfo.cache b/t/tests/files-general/debian/mimeinfo.cache
new file mode 100644
index 0000000..f3067c5
--- /dev/null
+++ b/t/tests/files-general/debian/mimeinfo.cache
@@ -0,0 +1,2 @@
+[MIME Cache]
+text/plain=foo-editor.desktop
diff --git a/t/tests/files-general/desc b/t/tests/files-general/desc
index 687a475..54caba0 100644
--- a/t/tests/files-general/desc
+++ b/t/tests/files-general/desc
@@ -14,6 +14,7 @@ Test-For:
  package-contains-empty-directory
  package-contains-info-dir-file
  package-contains-mime-cache-file
+ package-contains-mimeinfo.cache-file
  package-modifies-ld.so-search-path
  stray-directory-in-manpage-directory
  windows-devel-file-in-package
diff --git a/t/tests/files-general/tags b/t/tests/files-general/tags
index 9a45bda..55d3edd 100644
--- a/t/tests/files-general/tags
+++ b/t/tests/files-general/tags
@@ -5,6 +5,7 @@ E: files-general: global-data-in-games-directory usr/share/games/icons/hicolor/2
 E: files-general: non-conf-file-in-modprobe.d etc/modprobe.d/--lzma
 E: files-general: package-contains-info-dir-file usr/share/info/dir.gz
 E: files-general: package-contains-mime-cache-file usr/share/mime/types
+E: files-general: package-contains-mimeinfo.cache-file usr/share/applications/mimeinfo.cache
 E: files-general: package-modifies-ld.so-search-path etc/ld.so.conf.d/lintian-lib.conf
 E: files-general: stray-directory-in-manpage-directory usr/share/man/man1/random/
 I: files-general: duplicated-compressed-file usr/share/doc/lintian/lintian-16x16.png.gz

-- 
Debian package checker


Reply to: