[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#547631: Bug#547628: libclass-accessor-perl: breaks lintian



On Mon, Sep 21, 2009 at 11:08:53AM +0200, gregor herrmann wrote:
> JFTR: #547631 and #547628 address the same problem.

Lintian::Output uses multiple inheritance, and Class::Accessor introduced
an import subroutine in 0.34 that wins over Exporter::import().

I'm attaching a patch for lintian that should fix this.
Not sure if Class::Accessor actually did anything wrong here.
-- 
Niko Tyni   ntyni@debian.org
>From 095f6a200a8e840d7c8f3a396a65a3c2aae266be Mon Sep 17 00:00:00 2001
From: Niko Tyni <ntyni@debian.org>
Date: Mon, 21 Sep 2009 13:32:52 +0300
Subject: [PATCH] Make Lintian::Output work with Class::Accessor >= 0.34

As seen in <http://bugs.debian.org/547631>, the multiple inheritance
in Lintian::Output breaks with Class::Accessor >= 0.34 because the
default method resolution order finds Class::Accessor::import()
before Exporter::import().
---
 lib/Lintian/Output.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/Lintian/Output.pm b/lib/Lintian/Output.pm
index bb0ed82..e00e96c 100644
--- a/lib/Lintian/Output.pm
+++ b/lib/Lintian/Output.pm
@@ -22,7 +22,7 @@ use strict;
 use warnings;
 
 use v5.8.0; # for PerlIO
-use base qw(Class::Accessor Exporter);
+use base qw(Exporter Class::Accessor);
 
 # Force export as soon as possible, since some of the modules we load also
 # depend on us and the sequencing can cause things not to be exported
-- 
1.6.3.3


Reply to: