[SCM] Debian package checker branch, master, updated. 2.2.14-30-g19af980
The following commit has been merged in the master branch:
commit 0db8c662dd937f512376476aeb528e628f0b9b16
Author: Russ Allbery <rra@debian.org>
Date: Sun Sep 13 11:44:21 2009 -0700
Tweak severity and description of example script tags
Update several of the example script tags to wishlist since they seem
reasonable candidates for filing wishlist bugs. Leave
example-shell-script-fails-syntax-check and
example-unusual-interpreter as pedantic.
Add some more information to the syntax checking tags, since a common
cause is now /bin/sh scripts assuming bash. Add a bit more information
and the word example to the long descriptions of more of the example
tags.
diff --git a/checks/scripts.desc b/checks/scripts.desc
index 27932c4..e176894 100644
--- a/checks/scripts.desc
+++ b/checks/scripts.desc
@@ -13,10 +13,10 @@ Info: This file starts with the #! sequence that identifies scripts, but
it does not name an interpreter.
Tag: example-script-without-interpreter
-Severity: pedantic
+Severity: wishlist
Certainty: certain
-Info: This file starts with the #! sequence that identifies scripts, but
- it does not name an interpreter.
+Info: This example file starts with the #! sequence that identifies
+ scripts, but it does not name an interpreter.
Tag: executable-not-elf-or-script
Severity: normal
@@ -40,11 +40,12 @@ Info: This script uses a relative path to locate its interpreter.
the script's, so it is not likely to be what was intended.
Tag: example-interpreter-not-absolute
-Severity: pedantic
+Severity: wishlist
Certainty: certain
-Info: This script uses a relative path to locate its interpreter.
+Info: This example script uses a relative path to locate its interpreter.
This path will be taken relative to the caller's current directory, not
- the script's, so it is not likely to be what was intended.
+ the script's, so a user will probably not be able to run the example
+ without modification.
Tag: unusual-interpreter
Severity: normal
@@ -59,8 +60,7 @@ Severity: pedantic
Certainty: possible
Info: This package contains an example script for an interpreter that the
Lintian maintainers have not heard of. It could be a typo for a common
- interpreter. If not, please file a wishlist bug on lintian so that the
- Lintian maintainers can add this interpreter to their list.
+ interpreter.
Tag: script-uses-bin-env
Severity: normal
@@ -71,11 +71,12 @@ Info: This script uses /bin/env as its interpreter (used to find the
env in the script should be changed.
Tag: example-script-uses-bin-env
-Severity: pedantic
+Severity: wishlist
Certainty: certain
Info: This example script uses /bin/env as its interpreter (used to find
the actual interpreter on the user's path). There is no /bin/env on
- Debian systems; env is instead installed as /usr/bin/env.
+ Debian systems; env is instead installed as /usr/bin/env. Usually, the
+ pth to env in the script should be changed.
Tag: forbidden-config-interpreter
Severity: important
@@ -119,11 +120,12 @@ Info: This package contains a script that looks for an interpreter in a
/usr/local, this is the wrong place to look.
Tag: example-interpreter-in-usr-local
-Severity: pedantic
+Severity: wishlist
Certainty: certain
Info: This package contains an example script that looks for an
interpreter in a directory in /usr/local. Since Debian does not install
- anything in /usr/local, this is the wrong place to look.
+ anything in /usr/local, the example script would probably need
+ modifications before a user could run it.
Tag: control-interpreter-in-usr-local
Severity: serious
@@ -189,10 +191,11 @@ Info: The interpreter you used is installed at another location on Debian
systems.
Tag: example-wrong-path-for-interpreter
-Severity: pedantic
+Severity: wishlist
Certainty: certain
-Info: The interpreter used is installed at another location on Debian
- systems.
+Info: The interpreter used by this example script is installed at another
+ location on Debian systems. Normally the path should be updated to match
+ the Debian location.
Tag: gawk-script-but-no-gawk-dep
Severity: important
@@ -295,7 +298,9 @@ Tag: shell-script-fails-syntax-check
Severity: important
Certainty: certain
Info: Running this shell script with the shell's -n option set fails,
- which means that the script has syntax errors.
+ which means that the script has syntax errors. The most common cause of
+ this problem is a script expecting <tt>/bin/sh</tt> to be bash checked on
+ a system using dash as <tt>/bin/sh</tt>.
.
Run e.g. <tt>sh -n yourscript</tt> to see the errors yourself.
@@ -303,7 +308,9 @@ Tag: example-shell-script-fails-syntax-check
Severity: pedantic
Certainty: certain
Info: Running this shell script with the shell's -n option set fails,
- which means that the script has syntax errors.
+ which means that the script has syntax errors. The most common cause of
+ this problem is a script expecting <tt>/bin/sh</tt> to be bash checked on
+ a system using dash as <tt>/bin/sh</tt>.
.
Run e.g. <tt>sh -n yourscript</tt> to see the errors yourself.
diff --git a/debian/changelog b/debian/changelog
index d7cc228..f20e2fd 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -3,12 +3,12 @@ lintian (2.2.15) UNRELEASED; urgency=low
* Summary of tag changes:
+ Added:
- build-depends-on-non-build-package
- - example-interpreter-in-usr-local (pedantic)
- - example-interpreter-not-absolute (pedantic)
- - example-script-without-interpreter (pedantic)
- - example-script-uses-bin-env (pedantic)
+ - example-interpreter-in-usr-local
+ - example-interpreter-not-absolute
+ - example-script-without-interpreter
+ - example-script-uses-bin-env
- example-shell-script-fails-syntax-check (pedantic)
- - example-wrong-path-for-interpreter (pedantic)
+ - example-wrong-path-for-interpreter
- example-unusual-interpreter (pedantic)
- global-data-in-games-directory
@@ -73,7 +73,7 @@ lintian (2.2.15) UNRELEASED; urgency=low
(Closes: #543781)
+ [RA] Check example scripts for most of the same issues as scripts
elsewhere in the package, but report problems with a different set
- of tags with pedantic severity. Patch from Damyan Ivanov.
+ of tags with info or pedantic severity. Patch from Damyan Ivanov.
(Closes: #543873)
* data/fields/essential:
--
Debian package checker
Reply to: