[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.2.8-7-g223cc3b



The following commit has been merged in the master branch:
commit 223cc3b994f13c1433314a5ad582fb114b3fdc5f
Author: Russ Allbery <rra@debian.org>
Date:   Thu Mar 26 18:31:03 2009 -0700

    Fix uninitialized warnings in Lintian::Command::kill
    
    * lib/Lintian/Command.pm:
      + [RA] In kill, initialize the result status and use ||= instead of |=.
        Partly addresses #521257.

diff --git a/debian/changelog b/debian/changelog
index 15650f1..f9db1dd 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -19,6 +19,10 @@ lintian (2.2.9) UNRELEASED; urgency=low
   * frontend/lintian:
     + [RA] Belatedly bump the lab format version for many recent changes.
 
+  * lib/Lintian/Command.pm:
+    + [RA] In kill, initialize the result status and use ||= instead of |=.
+      Partly addresses #521257.
+
  -- Frank Lichtenheld <djpig@debian.org>  Mon, 16 Mar 2009 00:13:30 +0100
 
 lintian (2.2.8) unstable; urgency=low
diff --git a/lib/Lintian/Command.pm b/lib/Lintian/Command.pm
index 0292fea..1f935d2 100644
--- a/lib/Lintian/Command.pm
+++ b/lib/Lintian/Command.pm
@@ -303,9 +303,9 @@ all the executions of kill_kill.
 =cut
 
 sub kill {
-    my $status;
+    my $status = 0;
     while (my $opts = shift @_) {
-	$status |= kill_kill($opts->{'harness'}, grace => 2);
+	$status ||= kill_kill($opts->{'harness'}, grace => 2);
     }
     return $status;
 }

-- 
Debian package checker


Reply to: