Re: Plans for squeeze

[Raphael Geissert <atomo64+debian@gmail.com>]

Raphael Geissert wrote:

> Russ Allbery wrote:
> 
>> Raphael Geissert writes:
>>> Russ Allbery wrote:
>>>> I thought I responded to your patch with the specific details of what
>>>> else needs to be done, and I hadn't seen a further response after that.
>>>> Maybe Gmane dropped the message for some reason?  The main change,
>>>> IIRC, is that the package list format needs to be changed to include
>>>> the archive area so that we can display that information on the
>>>> lintian.d.o web pages.
>>>
>>> If that was the problem, I think I already addressed those in the last
>>> patch I sent to the BTS[1]; you later sent [2] where you removed the
>>> 'patch' tag.
>>>
>>> [1]http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=516530#57
>>> [2]http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=59;bug=516530
>> 
>> Oh, I owed you another reply.  Sorry, didn't realize that.
>> 
>> Looking at the last patch, though, I still don't see any sign of this
>> change to the package list format.  The only data being included is still
>> just:
>> 
>> +       print OUT join(';',
>> +                      $pkg,
>> +                      $data->{'version'},
>> +                      $data->{'source'},
>> +                      $data->{'source-version'},
>> +                      $deb_file,
>> +                      $timestamp,
>> +                      ),"\n";
>> 
>> and:
>> 
>> +    print OUT join(';',
>> +                  $pkg,
>> +                  $data->{'version'},
>> +                  $data->{'maintainer'},
>> +                  $data->{'uploaders'} || '',
>> +                  $data->{'architecture'},
>> +                  $data->{'standards-version'},
>> +                  $data->{'binary'},
>> +                  $data->{'files'},
>> +                  $dsc_file,
>> +                  $timestamp,
>> +                  ),"\n";
>> 
>> which doesn't include the archive area.  Am I missing something?
>> 
> 
> No, not at all. I missed that part, although I did modify
> lib/Read_pkglists.pm so that it could read that info. I'll make those
> changes and re-send it to the BTS. Thanks for reviewing it.
> 

I'm confused now. Just noticed that I had indeed, as I originally suspected,
made the change on my local repo, and confirmed it in the last mbox I sent.

@@ -166,6 +176,7 @@ foreach my $sources (@sources) {
                   $data->{'maintainer'},
                   $data->{'uploaders'} || '',
                   $data->{'architecture'},
+                  $sources->{'area'},
                   $data->{'standards-version'},
                   $data->{'binary'},
                   $data->{'files'},

@@ -171,6 +180,7 @@ foreach my $packages (@packages) {
                       $data->{'source-version'},
                       $deb_file,
                       $timestamp,
+                      $packages->{'area'},
                       ),"\n";

Am I missing something? those changes are included in the second patch of
the mbox.

By the way, what do you think about using File::Libmagic instead of file on
the collection scripts? It would surely speed up the collection.
By the way, I find the collection/scripts script sub-optimal as if the
information was also collected via the same collection script obtaining the
file(1) information, less read operations would be required. The idea would
be to merge both scripts, although I don't know very well how many bytes
should be passed to libmagic for it to correctly determine all the
necessary information. Any idea? comments?

Cheers,
-- 
Raphael Geissert - Debian Maintainer
www.debian.org - get.debian.net