Bug#519268: lintian: diversion warnings unreliable, fails on for-loops

[Rene Engelhard <rene@debian.org>]

Package: lintian
Version: 2.2.7
Severity: normal

Hi,

W: broffice.org: binary-without-manpage usr/bin/broffice
E: broffice.org: remove-of-unknown-diversion $i postrm:106
E: broffice.org: remove-of-unknown-diversion usr/lib/openoffice/program/resource/ooo$i.res postrm:109
E: broffice.org: diversion-for-unknown-file $i preinst:107
N: 
N:    The maintainer script adds a diversion for a file that is not provided
N:    by this package.
N:    
N:    Severity: important, Certainty: certain
N: 
E: broffice.org: diversion-for-unknown-file usr/lib/openoffice/program/resource/ooo$i.res preinst:110
E: broffice.org: orphaned-diversion $i preinst
E: broffice.org: orphaned-diversion usr/lib/openoffice/program/resource/ooo$i.res preinst

Eh, what?

Let's look in the postrm (analogous with the others):

DIVERSIONS="/usr/lib/openoffice/program/bootstraprc /usr/lib/openoffice/program/versionrc /usr/lib/openoffice/share/registry/modules/org/openoffice/Setup/Setup-brand.xcu /usr/share/applications/ooo-calc.desktop /usr/share/applications/ooo-writer.desktop /usr/share/applications/ooo-draw.desktop /usr/share/applications/ooo-base.desktop /usr/share/applications/ooo-impress.desktop /usr/share/applications/ooo-math.desktop /usr/share/applications/ooo-extensionmgr.desktop /usr/share/applications/ooo-startcenter.desktop /usr/share/application-registry/openoffice.applications /usr/share/mimelnk/application/vnd.openofficeorg.extension.desktop /usr/share/mime-info/openoffice.keys /usr/lib/openoffice/share/registry/modules/org/openoffice/Office/UI/UI-brand.xcu"
DIVERSIONS="$DIVERSIONS /usr/lib/openoffice/program/intro.bmp /usr/lib/openoffice/program/about.bmp"
[...]
if [ "$1" = "remove" ]; then
        for i in $DIVERSIONS; do
                dpkg-divert --package $THIS_PACKAGE --remove --rename --divert $i.ooo $i

                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
		This is line 1096.

        done
        for i in $LANGPACKISOS; do
                dpkg-divert --package $THIS_PACKAGE --remove --rename --divert /usr/lib/openoffice/program/resource/ooo$i.res.ooo /usr/lib/openoffice/program/resource/ooo$i.res
        done
fi

You dont really want me to call dpkg-divert for all them (and all languages)
manually (and easily being able to forget a new langauge or branding file?)

I'll override this.

Regards,

Rene

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.28-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages lintian depends on:
ii  binutils               2.19.1-1          The GNU assembler, linker and bina
ii  diffstat               1.46-1            produces graph of changes introduc
ii  dpkg-dev               1.14.25           Debian package development tools
ii  file                   4.26-2            Determines file type using "magic"
ii  gettext                0.17-6            GNU Internationalization utilities
ii  intltool-debian        0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii  libipc-run-perl        0.82-1            Perl module for running processes
ii  libparse-debianchangel 1.1.1-2           parse Debian changelogs and output
ii  libtimedate-perl       1.1600-9          Time and date functions for Perl
ii  liburi-perl            1.37+dfsg-1       Manipulates and accesses URI strin
ii  man-db                 2.5.4-1           on-line manual pager
ii  perl [libdigest-sha-pe 5.10.0-19         Larry Wall's Practical Extraction 

lintian recommends no packages.

Versions of packages lintian suggests:
pn  binutils-multiarch            <none>     (no description available)
ii  libtext-template-perl         1.44-1.2   Text::Template perl module
ii  man-db                        2.5.4-1    on-line manual pager

-- debconf-show failed