[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.2.6-58-g63c78f2



The following commit has been merged in the master branch:
commit 75ad7f0e81a27db3f3b900de194c3c29a62e8503
Author: Russ Allbery <rra@debian.org>
Date:   Sun Mar 8 15:30:14 2009 -0700

    Fix the exit status of reap()
    
    reap() was returning true if any of the reaped jobs succeeded.  Only
    return true if all of them have succeeded, and use logical operators
    instead of bitwise operators to do it.

diff --git a/lib/Lintian/Command.pm b/lib/Lintian/Command.pm
index 530f2df..4a07d1d 100644
--- a/lib/Lintian/Command.pm
+++ b/lib/Lintian/Command.pm
@@ -264,7 +264,7 @@ All other keys are probably just ignored.
 =cut
 
 sub reap {
-    my $status;
+    my $status = 1;
     while (my $opts = shift @_) {
 	next unless defined($opts->{harness});
 
@@ -287,7 +287,7 @@ sub reap {
 			   $opts->{harness}->result);
 	    }
 	}
-	$status |= $opts->{success};
+	$status &&= $opts->{success};
     }
     return $status;
 }

-- 
Debian package checker


Reply to: