[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#515690: embedded-javascript-library: not so certain



On Sat, 2009-02-21 at 16:04 -0800, Russ Allbery wrote:
> "Adam D. Barratt" <adam@adam-barratt.org.uk> writes:
> > Lowering the severity to Possible still includes the tag in the default
> > output and continues to equate to a warning tag so I'm likely to do so
> > shortly unless anyone has any objections, at least for the Javascript
> > and PHP checks.
> 
> Yes, please.  I don't think anything that just matches a filename should
> be Certain.

I agree.

> I think we should also seriously consider deleting the regex for yahoo.js
> until someone develops a file content check for it, since we know it has
> false positives, unless someone feels strongly that this is something we
> really need to check.

It's a compound regex matching yahoo.js together with
yahoo-{dom,event,min}.js.  I'll modify it purely to match the latter.

Adam



Reply to: