[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#513946: marked as done (lintian: should not tag copyright-refers-to-versionless-license-file when using 'GPL-2+')



Your message dated Sun, 08 Feb 2009 03:47:05 +0000
with message-id <E1LW0dN-0007U3-ST@ries.debian.org>
and subject line Bug#513946: fixed in lintian 2.2.3
has caused the Debian Bug report #513946,
regarding lintian: should not tag copyright-refers-to-versionless-license-file when using 'GPL-2+'
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
513946: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=513946
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: lintian
Version: 2.2.2
Severity: wishlist
Tags: patch

Hey,

currently lintian will tag a source with copyright-refers-to-versionless-license-file
when one refers to a license symlink and lintian can't find 
\b(any|or)\s+later(\s+version)?\b
in the copyright file.

That is imho wrong, esp with the new copyright format:
Files: foo
Copyright: bar
License: GPL-2+
That says foo is licensed under gpl v2 or later.

The attached patch against git solves the issue for me.

regards
Evgeni

-- System Information:
Debian Release: 5.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.28-z61m-1 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils            2.18.1~cvs20080103-7 The GNU assembler, linker and bina
ii  diffstat            1.46-1               produces graph of changes introduc
ii  dpkg-dev            1.14.24              Debian package development tools
ii  file                4.26-2               Determines file type using "magic"
ii  gettext             0.17-6               GNU Internationalization utilities
ii  intltool-debian     0.35.0+20060710.1    Help i18n of RFC822 compliant conf
ii  libipc-run-perl     0.82-1               Perl module for running processes
ii  libparse-debianchan 1.1.1-2              parse Debian changelogs and output
ii  libtimedate-perl    1.1600-9             Time and date functions for Perl
ii  liburi-perl         1.37+dfsg-1          Manipulates and accesses URI strin
ii  man-db              2.5.2-4              on-line manual pager
ii  perl [libdigest-sha 5.10.0-19            Larry Wall's Practical Extraction 

lintian recommends no packages.

Versions of packages lintian suggests:
pn  binutils-multiarch            <none>     (no description available)
pn  libtext-template-perl         <none>     (no description available)
ii  man-db                        2.5.2-4    on-line manual pager

-- no debconf information
>From b8cc161335fed98e57d0a8e359dba32f2f209de1 Mon Sep 17 00:00:00 2001
From: Evgeni Golov <sargentd@die-welt.net>
Date: Mon, 2 Feb 2009 18:09:53 +0100
Subject: [PATCH] read $license-X+ as $license X or later in debian/copyright

---
 checks/copyright-file |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/checks/copyright-file b/checks/copyright-file
index fbfbd72..4c870f4 100644
--- a/checks/copyright-file
+++ b/checks/copyright-file
@@ -156,7 +156,8 @@ if (m,usr/share/common-licenses/(GPL|LGPL|BSD|Artistic)\.gz,) {
 if (m,(usr/share/common-licenses/(L?GPL|GFDL))[^-],i && !m,as Perl itself,i
     && !m,License-Alias:\s+Perl,) {
     my $ref = $1;
-    if (m,\b(any|or)\s+later(\s+version)?\b,i) {
+    my $license = $2;
+    if (m,\b(any|or)\s+later(\s+version)?\b,i || m,License: $license-[\d\.]+\+,i) {
 	tag "copyright-refers-to-symlink-license", $ref;
     } else {
 	tag "copyright-refers-to-versionless-license-file", $ref;
-- 
1.5.6.5


--- End Message ---
--- Begin Message ---
Source: lintian
Source-Version: 2.2.3

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive:

lintian_2.2.3.dsc
  to pool/main/l/lintian/lintian_2.2.3.dsc
lintian_2.2.3.tar.gz
  to pool/main/l/lintian/lintian_2.2.3.tar.gz
lintian_2.2.3_all.deb
  to pool/main/l/lintian/lintian_2.2.3_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 513946@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Russ Allbery <rra@debian.org> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 07 Feb 2009 19:19:45 -0800
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.2.3
Distribution: unstable
Urgency: low
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Russ Allbery <rra@debian.org>
Description: 
 lintian    - Debian package checker
Closes: 119045 127494 339829 483845 507849 513946 514095 514203 514491 514496
Changes: 
 lintian (2.2.3) unstable; urgency=low
 .
   * Summary of tag changes:
     + Added
       - description-possibly-contains-homepage
       - dfsg-version-in-native-package
       - dfsg-version-with-period
       - dfsg-version-misspelled
       - experimental-to-unstable-without-comment (pedantic)
       - homepage-for-cpan-package-contains-version
       - maintainer-script-without-set-e (pedantic)
       - source-contains-prebuilt-binary (pedantic)
       - source-contains-prebuilt-windows-binary (pedantic)
       - using-first-person-in-description
     + Removed
       - non-us-spelling
 .
   * checks/changelog-file{,.desc}:
     + [RA] Add pedantic check for a distribution of unstable when the last
       version had a distribution of experimental and there's no comment
       about the change.  (Closes: #483845)
   * checks/common-data.pm:
     + [ADB] Remove the obsolete non-US from the list of recognised archive
       sections.
   * checks/copyright-file:
     + [RA] Treat License: GPL-2+ as "GPL version 2 or later" for the
       purposes of the check for a correctly versioned license reference.
       Patch from Evgeni Golov.  (Closes: #513946)
   * checks/cruft{,.desc}:
     + [RA] Downgrade all source-contains-* tags to pedantic.  These are
       upstream problems the packager can't do much about and they have
       no practical effect on the Debian package.  Wishlist implies that
       a wishlist bug against the package would be appropriate, which
       seems too strong.
     + [RA] Add pedantic check for binaries in the upstream source.  Patch
       from Raphael Geissert.  (Closes: #127494)
   * checks/description{,.desc}:
     + [RA] Check for using first person in package descriptions, similar
       to the existing check for debconf questions.  Patch from Raphael
       Geissert.  (Closes: #514491)
     + [RA] Add check (wishlist/wild-guess) for apparent home page URLs in
       the long description with no Homepage field.  Based on a patch by
       Paul Wise.  (Closes: #339829)
   * checks/fields{,.desc}:
     + [ADB] Remove checks for the capitalisation of the obsolete non-US
       archive section.
     + [RA] Warn about Homepage fields pointing to search.cpan.org pages
       containing a version number.  Based on a patch by Paul Wise.
     + [RA] Warn of dfsg versions in native packages.
     + [RA] Warn of ".dfsg" versions and recommend "+dfsg" for version
       sorting reasons.  Thanks, Paul Wise.  (Closes: #514203)
     + [RA] Warn of the "dsfg" typo in versions.  Thanks, Paul Wise.
     + [RA] Use Lintian::Relation and the new Lintian::Collect support for
       retrieving parsed relationship fields.
   * checks/files:
     + [ADB] Don't report duplicate-font-file for udebs.  Patch by Raphael
       Geissert.  (Closes: #514095)
   * checks/scripts{,.desc}:
     + [RA] Add pedantic check for maintainer scripts using #!/bin/sh -e
       instead of set -e in the script body.  (Closes: #119045)
 .
   * collection/file-info{,.desc}:
     + [RA] Also run file-info for source packages.  Patch from Raphael
       Geissert.
 .
   * lib/Lintian/Collect.pm:
     + [RA] Defer loading of the subclasses until the constructor to avoid
       circular dependencies at compilation time.
   * lib/Lintian/Collect/Binary.pm:
     + [RA] New method relation() to return a Lintian::Relation object for
       a given relationship field or set of relationship fields.
   * lib/Lintian/Collect/Source.pm:
     + [RA] New methods relation() and relation_noarch() to return
       Lintian::Relation objects for a given build relationship field or
       set of fields.  New method binary_relation() to return a
       Lintian::Relation object for a given relationship field in a binary
       package built from this source package.
     + [RA] Add file_info() method to return file information for source
       packages.  Patch from Raphael Geissert.
   * lib/Lintian/Relation.pm:
     + [RA] New class based on the existing Dep module that handles package
       relationship analysis.  Now includes documentation, uses a more
       object-oriented structure, and removes a special case handling of
       Perl alternatives.  This module will eventually replace Dep.
   * lib/Lintian/Relation/Version.pm:
     + [RA] New module containing the version comparison code from Dep.
       This module will only be needed until Lintian is converted to
       Dpkg::Version or AptPkg::Version.
   * lib/Spelling.pm:
     + [RA] Add some additional typo and case corrections.  Patch from
       Raphael Geissert.
 .
   * t/runtests:
     + [RA] Copy test suite data based on checksum, not size and time,
       since some files change one character and Git doesn't preserve
       timestamps.  Patch from Raphael Geissert.  (Closes: #514496)
 .
   * unpack/list-{binpkg,udebpkg}:
     + [RA] Preserve the source_version field from the previous list when
       adding new packages, remove some dead code, and restructure for
       improved readability.  Thanks to Jordà Polo for the analysis.
       (Closes: #507849)
     + [RA] Generate an index of files in the upstream source tarball.
       Patch from Raphael Geissert.
Checksums-Sha1: 
 ff8957770ad16068d63c46f5c4ba45bbf3355506 1163 lintian_2.2.3.dsc
 590d3f601eb36d120e543e24e8e9bdcba7b24fde 616409 lintian_2.2.3.tar.gz
 58ae86116267035625985185ff946feaa97da8d0 432674 lintian_2.2.3_all.deb
Checksums-Sha256: 
 65f3b45bf736d01813cd5987232294c03bb16c9a1c9a22a294b8849c924cc3b0 1163 lintian_2.2.3.dsc
 7eabdfa5a0a51f3fc8bbf94b17cd1692c12b0ae586b4dbc987acd1ba0006cb31 616409 lintian_2.2.3.tar.gz
 ae7681e35a29251a7598357a4c9fd6e0cbb9701663cea72eeb552f6934619890 432674 lintian_2.2.3_all.deb
Files: 
 75d431f09f49c41fd4de2ab337b7cc4a 1163 devel optional lintian_2.2.3.dsc
 15f1e82e176244ede72da6cda7cd753d 616409 devel optional lintian_2.2.3.tar.gz
 93ca095d0dab2925d12d91a019f1272c 432674 devel optional lintian_2.2.3_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkmOU6QACgkQ+YXjQAr8dHbiWQCeP6M7BO4Rhq/ErDNXliYdJJXl
sxAAniP9X7IRZ9j2yzX4atiC0g/Dh4mG
=Fykp
-----END PGP SIGNATURE-----



--- End Message ---

Reply to: