[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.2.2-14-g5ed87d4



The following commit has been merged in the master branch:
commit 5ed87d401fdb543df7cfc38386a61148258b16b7
Author: Russ Allbery <rra@debian.org>
Date:   Fri Feb 6 22:25:44 2009 -0800

    Add check for switching from experimental to unstable without comment
    
    * checks/changelog-file{,.desc}:
      + [RA] Add pedantic check for a distribution of unstable when the last
        version had a distribution of experimental and there's no comment
        about the change.  (Closes: #483845)

diff --git a/checks/changelog-file b/checks/changelog-file
index 2996d73..4fa112e 100644
--- a/checks/changelog-file
+++ b/checks/changelog-file
@@ -293,6 +293,14 @@ if (@entries) {
 	    tag "latest-debian-changelog-entry-changed-to-native"
 		if $native_pkg and $second_version =~ m/-/;
 	}
+
+	my $first_dist = lc $entries[0]->Distribution;
+	my $second_dist = lc $entries[1]->Distribution;
+	if ($first_dist eq 'unstable' and $second_dist eq 'experimental') {
+	    unless ($entries[0]->Changes =~ /\bto\s+unstable\b/) {
+		tag "experimental-to-unstable-without-comment";
+	    }
+	}
     }
 
     # Some checks should only be done against the most recent changelog entry.
@@ -396,4 +404,8 @@ close IN;
 
 1;
 
+# Local Variables:
+# indent-tabs-mode: t
+# cperl-indent-level: 4
+# End:
 # vim: syntax=perl ts=8 sw=4
diff --git a/checks/changelog-file.desc b/checks/changelog-file.desc
index 21635b5..82222c8 100644
--- a/checks/changelog-file.desc
+++ b/checks/changelog-file.desc
@@ -201,6 +201,16 @@ Info: The latest package has a Debian native version number, while the
  the maintainer by forgetting to append -1 when uploading a new upstream
  version.
 
+Tag: experimental-to-unstable-without-comment
+Severity: pedantic
+Certainty: possible
+Info: The previous version of this package had a distribution of
+ experimental, this version has a distribution of unstable, and there's
+ apparently no comment about the change of distributions (Lintian looks
+ for the phrase "to unstable").  This may indicate a mistake in setting
+ the distribution and accidentally uploading to unstable a package
+ intended for experimental.
+
 Tag: syntax-error-in-debian-changelog
 Severity: normal
 Certainty: possible
diff --git a/debian/changelog b/debian/changelog
index 60cf21b..ac4e7ae 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -3,11 +3,16 @@ lintian (2.2.3) UNRELEASED; urgency=low
   * Summary of tag changes:
     + Added
       - description-possibly-contains-homepage (pedantic)
+      - experimental-to-unstable-without-comment (pedantic)
       - homepage-for-cpan-package-contains-version
       - using-first-person-in-description
     + Removed
       - non-us-spelling
 
+  * checks/changelog-file{,.desc}:
+    + [RA] Add pedantic check for a distribution of unstable when the last
+      version had a distribution of experimental and there's no comment
+      about the change.  (Closes: #483845)
   * checks/common-data.pm:
     + [ADB] Remove the obsolete non-US from the list of recognised archive
       sections.
diff --git a/t/tests/changelog-file-experimental/debian/debian/changelog.in b/t/tests/changelog-file-experimental/debian/debian/changelog.in
new file mode 100644
index 0000000..3b51ba2
--- /dev/null
+++ b/t/tests/changelog-file-experimental/debian/debian/changelog.in
@@ -0,0 +1,12 @@
+{$srcpkg} ({$version}) unstable; urgency=low
+
+  * Lintian Test Suite.
+  * Test: {$testname}
+
+ -- {$author}  {$date}
+
+{$srcpkg} (0.1) experimental; urgency=low
+
+  * First upload to experimental.
+
+ -- {$author}  Fri, 06 Feb 2009 22:22:37 -0800
diff --git a/t/tests/changelog-file-experimental/desc b/t/tests/changelog-file-experimental/desc
new file mode 100644
index 0000000..06dcd9b
--- /dev/null
+++ b/t/tests/changelog-file-experimental/desc
@@ -0,0 +1,7 @@
+Testname: changelog-file-experimental
+Sequence: 6000
+Version: 1.0
+Description: Check experimental to unstable changes
+Skeleton: pedantic
+Options: --pedantic -I -E
+Check-For: experimental-to-unstable-without-comment
diff --git a/t/tests/changelog-file-experimental/tags b/t/tests/changelog-file-experimental/tags
new file mode 100644
index 0000000..288e37f
--- /dev/null
+++ b/t/tests/changelog-file-experimental/tags
@@ -0,0 +1 @@
+P: changelog-file-experimental: experimental-to-unstable-without-comment

-- 
Debian package checker


Reply to: