[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.3.0-39-g5ae0b8e



The following commit has been merged in the master branch:
commit dcdf14044c33ea1322ccab1f9da885ea55483237
Author: Raphael Geissert <atomo64@gmail.com>
Date:   Wed Dec 30 19:16:13 2009 -0600

    Avoid false positives on init scripts using '/var*' or '/usr*' files
    
    * checks/init.d.desc:
      + [RG] Tighten check for missing dependency on local_fs or remote_fs
        when using files with a name of 'var*' or 'usr*'.

diff --git a/checks/init.d b/checks/init.d
index f2d633e..fcb3c0f 100644
--- a/checks/init.d
+++ b/checks/init.d
@@ -246,8 +246,8 @@ sub check_init {
 
 	# This should be more sophisticated: ignore heredocs, ignore quoted
 	# text and the arguments to echo, etc.
-	$needs_fs{'remote'} = 1 if ($l =~ m,^[^\#]*/usr,);
-	$needs_fs{'local'}  = 1 if ($l =~ m,^[^\#]*/var,);
+	$needs_fs{'remote'} = 1 if ($l =~ m,^[^\#]*/usr/,);
+	$needs_fs{'local'}  = 1 if ($l =~ m,^[^\#]*/var/,);
 
 	while ($l =~ s/^[^\#]*?(start|stop|restart|force-reload)//o) {
 	    $tag{$1} = 1;
diff --git a/debian/changelog b/debian/changelog
index 144e0f2..a092024 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -29,6 +29,8 @@ lintian (2.3.1) UNRELEASED; urgency=low
     + [RG] Mention 'killprocs' in init.d-script-possible-missing-stop's
       description.  Thanks, Kurt Roeckx.  (Closes: #562608)
     + [RG] Warn about init scripts with incomplete start runlevels.
+    + [RG] Tighten check for missing dependency on local_fs or remote_fs
+      when using files with a name of 'var*' or 'usr*'.
   * checks/manpages.desc:
     + [RA] Downgrade spelling-error-in-manpage to minor severity.
       (Closes: #563039)
diff --git a/t/tests/init.d-lsb-headers/debian/debian/init.d-lsb-headers-missing.init b/t/tests/init.d-lsb-headers/debian/debian/init.d-lsb-headers-missing.init
index 651e3d6..bacd32f 100644
--- a/t/tests/init.d-lsb-headers/debian/debian/init.d-lsb-headers-missing.init
+++ b/t/tests/init.d-lsb-headers/debian/debian/init.d-lsb-headers-missing.init
@@ -11,6 +11,8 @@ set -e
 # Short-Description: Just a test script
 ### END INIT INFO
 
+. /lib/init/vars.sh
+
 case "$1" in
     start|stop|force-reload|restart|status|*)
 	echo hello world

-- 
Debian package checker


Reply to: