Bug#562630: [reporting/] EWI code displayed at the top of the pages is changed to O if all tags are overridden
Raphael Geissert <geissert@debian.org> writes:
> 2009/12/26 Adam D. Barratt <adam@adam-barratt.org.uk>:
>> On Sat, December 26, 2009 17:29, Raphael Geissert wrote:
>>> I just found this little bug as demonstrated in [1]. I think I know
>>> why it is happening, but I don't know all of the reporting/ code very
>>> well.
>>> [1]http://lintian.debian.org/tags/init.d-script-not-included-in-package.html
>> This actually appears to be intentional, as per commit
>> 0e3515671b1c6f6a0e7cb94fcf00a5c936a6abc0 by Frank about 18 months ago.
>> The surrounding code has seen a few changes since then, but the section
>> setting $code (as used in the template) is still as the commit above.
> I don't see what would be the reason for that change (the defaulting
> to 'O' mainly).
I think that commit is solving a different problem and the change to using
O is a side effect that was already present in the previous code. The
previous code used whatever code was on the first instance of that tag
seen by Lintian. The new code tries to find a code other than O and only
gives up and uses O if every tag is overridden.
>>> This bug might actually be very easy to fix with the new
>>> Lintian::Tag::Info module.
Yup, that looks like the right fix to me as well. I'll check that in.
--
Russ Allbery (rra@debian.org) <http://www.eyrie.org/~eagle/>
Reply to: