Bug#557530: Missing autotools* check in build-depends-indep relation

[Guillaume Delacour <gui@iroqwa.org>]

Package: lintian
Version: 2.2.18
Severity: normal
Tags: patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I discovered that lintian don't check autotools and variant in "Build-Depends-Indep" into check "cruft" (outdated-autotools-helper-file).

Please find in attachment a proposal to fix this.


- -- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (90, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.31-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages lintian depends on:
ii  binutils               2.20-4            The GNU assembler, linker and bina
ii  diffstat               1.47-1            produces graph of changes introduc
ii  dpkg-dev               1.15.4.1          Debian package development tools
ii  file                   5.03-3            Determines file type using "magic"
ii  gettext                0.17-8            GNU Internationalization utilities
ii  intltool-debian        0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii  libapt-pkg-perl        0.1.24            Perl interface to libapt-pkg
ii  libclass-accessor-perl 0.34-1            Perl module that automatically gen
ii  libipc-run-perl        0.84-1            Perl module for running processes
ii  libparse-debianchangel 1.1.1-2           parse Debian changelogs and output
ii  libtimedate-perl       1.1900-1          Time and date functions for Perl
ii  liburi-perl            1.37+dfsg-1       Manipulates and accesses URI strin
ii  man-db                 2.5.6-4           on-line manual pager
ii  perl [libdigest-sha-pe 5.10.1-8          Larry Wall's Practical Extraction 

lintian recommends no packages.

Versions of packages lintian suggests:
pn  binutils-multiarch            <none>     (no description available)
pn  libtext-template-perl         <none>     (no description available)
ii  man-db                        2.5.6-4    on-line manual pager

- -- no debconf information

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAksJcDUACgkQ35KHK503hANRrwCfWYd2iG+FUFqAHaMUuu1WxEjK
5msAniTA1pMpeEb6708DdJQjZ6Yb6cyi
=I3iM
-----END PGP SIGNATURE-----

--- cruft.orig	2009-11-13 08:36:39.000000000 +0100
+++ cruft	2009-11-22 17:29:20.000000000 +0100
@@ -113,6 +113,7 @@
 
 # Check if the package build-depends on autotools-dev, automake, or libtool.
 my $atdinbd = $info->relation('build-depends')->implies($AUTOTOOLS);
+my $atdinbdi = $info->relation('build-depends-indep')->implies($AUTOTOOLS);
 my $ltinbd  = $info->relation('build-depends')->implies('libtool');
 
 # Create a closure so that we can pass our lexical variables into the find
@@ -126,7 +127,7 @@
 } elsif (not $info->native) {
     check_diffstat("diffstat", \%warned);
 }
-my $wanted = sub { find_cruft($pkg, $info, \%warned, $atdinbd, $ltinbd) };
+my $wanted = sub { find_cruft($pkg, $info, \%warned, $atdinbd, $atdinbdi, $ltinbd) };
 find($wanted, 'unpacked');
 
 # Look for cruft based on file's results, but allow cruft in test directories
@@ -271,7 +272,7 @@
 # "source-contains" tag.  The tag isn't entirely accurate, but it's better
 # than creating yet a third set of tags, and this gets the severity right.
 sub find_cruft {
-    my ($pkg, $info, $warned, $atdinbd, $ltinbd) = @_;
+    my ($pkg, $info, $warned, $atdinbd, $atdinbdi, $ltinbd) = @_;
     (my $name = $File::Find::name) =~ s,^(\./)?unpacked/,,;
 
     # Ignore files in test suites.  They may be part of the test.
@@ -306,7 +307,7 @@
         if ($name !~ m,^debian/config\.cache$,) {
             tag "configure-generated-file-in-source", $name;
         }
-    } elsif ($name =~ m,^(.+/)?config.(?:guess|sub)$, and not $atdinbd) {
+    } elsif ($name =~ m,^(.+/)?config.(?:guess|sub)$, and not $atdinbd, and not $atdinbdi) {
         my $b = basename $name;
         open (F, '<', $b) or die "can't open $name: $!";
         while (<F>) {