[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#536397: lintian: False positive with command-with-path-in-maintainer-script

Russ Allbery wrote:
> How about:
> our $LEADIN =
>    qr'(?:(?:^|[&;(|{]|^(?:[^`]|`[^`]*`)*`)\s*|(?:if|then|do|while)\s+)';

It should be at least non-greedy.

> Hm.  Although then I bet we get ourselves in trouble by matching too
> much and don't check the command in the first backticks.

To avoid that we'd need to use \G and friends. The only problem is that we'd
need to modify every use of LEADIN to handle that, so I'm not quite sure
that's the best option.

> I'm not quite sure the best way to solve this.  Maybe extract all
> backticked commands from the string and check them independently before
> checking the main string?

Yeah, this is mostly what I said on #530815. But it'd be better in a
separate class so that we can reuse it. I haven't started working on it
mainly because I can't think of a good design for the class (I guess I'll
have to use TDD, otherwise I won't do anything any time soon).

Raphael Geissert - Debian Developer
www.debian.org - get.debian.net

Reply to: