[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.2.10-86-g6da1332



The following commit has been merged in the master branch:
commit 91f9919cb612382291ab2a18dd960e044b5165a2
Author: Adam D. Barratt <adam@adam-barratt.org.uk>
Date:   Thu Jun 4 20:56:13 2009 +0100

    Don't flag "\\" as an unsafe backslash escape in shell scripts
    
    * checks/scripts:
      + [ADB] Remove "\\" from the list of unsafe backslash escapes in the
        shell script checks.  POSIX does not prohibit its use and it works
        in all shells in Debian.

diff --git a/checks/scripts b/checks/scripts
index 7c86dde..35ddd88 100644
--- a/checks/scripts
+++ b/checks/scripts
@@ -193,7 +193,7 @@ our @depends_needed = (
 our $LEADIN = qr'(?:(?:^|[`&;(|{])\s*|(?:if|then|do|while)\s+)';
 
 our @bashism_single_quote_regexs = (
-    $LEADIN . qr'echo\s+(?:-[^e\s]+\s+)?\'[^\']*(\\[\\abcEfnrtv0])+.*?[\']',
+    $LEADIN . qr'echo\s+(?:-[^e\s]+\s+)?\'[^\']*(\\[abcEfnrtv0])+.*?[\']',
 	# unsafe echo with backslashes
     $LEADIN . qr'source\s+[\"\']?(?:\.\/|\/|\$|[\w.-])[^\s]+',
 	# should be '.', not 'source'
@@ -218,7 +218,7 @@ our @bashism_string_regexs = (
     qr'\$\{?PIPESTATUS\}?\b',      # $PIPESTATUS
     qr'\$\{?SHLVL\}?\b',	         # $SHLVL
     qr'<<<',                       # <<< here string
-    $LEADIN . qr'echo\s+(?:-[^e\s]+\s+)?\"[^\"]*(\\[\\abcEfnrtv0])+.*?[\"]',
+    $LEADIN . qr'echo\s+(?:-[^e\s]+\s+)?\"[^\"]*(\\[abcEfnrtv0])+.*?[\"]',
 	# unsafe echo with backslashes
 );
 our @bashism_regexs = (
diff --git a/debian/changelog b/debian/changelog
index fabe51f..1d3eaa5 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -75,6 +75,9 @@ lintian (2.2.11) UNRELEASED; urgency=low
     + [ADB] Fix a syntax error in the shellscript wrapper detection that lead
       to it returning a part of the wrapper script rather than a simple
       success value.
+    + [ADB] Remove "\\" from the list of unsafe backslash escapes in the
+      shell script checks.  POSIX does not prohibit its use and it works in
+      all shells in Debian.
   * checks/shared-libs.desc:
     + [RA] Downgrade certainty of tags for which we recommend overrides.
       Patch from Raphael Geissert.

-- 
Debian package checker


Reply to: