[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.2.10-62-gd7fb22c



The following commit has been merged in the master branch:
commit d7fb22c83ee27686a8ae510f7f5bdc95f7a784d7
Author: Raphael Geissert <atomo64@gmail.com>
Date:   Thu May 28 20:53:03 2009 +0100

    Detect arguments passed to sourced scripts inside conditional statements
    
    * checks/scripts:
        + [ADB] Detect the use of ". foo bar" (passing arguments to a sourced
          script) inside a conditional statement.  Thanks, Raphael Geissert.

diff --git a/checks/scripts b/checks/scripts
index 8440d2b..4ff2fa2 100644
--- a/checks/scripts
+++ b/checks/scripts
@@ -700,8 +700,8 @@ while (<SCRIPTS>) {
 		# detect source (.) trying to pass args to the command it runs
 		# The first expression weeds out '. "foo bar"'
 		if (not $found and
-		    not m/^\s*\.\s+(\"[^\"]+\"|\'[^\']+\')\s*(\&|\||\d?>|<|;|\Z)/
-		    and m/^\s*(\.\s+[^\s;\`:]+\s+([^\s;]+))/) {
+		    not m/$LEADIN\.\s+(\"[^\"]+\"|\'[^\']+\')\s*(\&|\||\d?>|<|;|\Z)/
+		    and m/$LEADIN(\.\s+[^\s;\`:]+\s+([^\s;]+))/) {
 
 		    my $extra;
 		    ($match, $extra) = ($1, $2);
diff --git a/debian/changelog b/debian/changelog
index 604de1f..4e24d8e 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -54,6 +54,8 @@ lintian (2.2.11) UNRELEASED; urgency=low
       alternative.  Thanks, Guillaume Delacour.  (Closes: #529457)
     + [ADB] Detect shellscript wrappers which embed a call to "exec" in a
       conditional statement.  Thanks, Raphael Geissert.
+    + [ADB] Detect the use of ". foo bar" (passing arguments to a sourced
+      script) inside a conditional statement.  Thanks, Raphael Geissert.
   * checks/shared-libs.desc:
     + [RA] Downgrade certainty of tags for which we recommend overrides.
       Patch from Raphael Geissert.

-- 
Debian package checker


Reply to: