[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.2.5-57-g6bf7673



The following commit has been merged in the master branch:
commit 6bf76739655e8f7515d2bf6dfda80f02fa89f051
Author: Russ Allbery <rra@debian.org>
Date:   Sat Feb 21 21:47:23 2009 -0800

    Fix improbable-bug-number-in-closes so that it works
    
    * checks/changelog-file:
      + [RA] Fix improbable-bug-number-in-closes so that it works.
    
    The return value of Closes is a reference to an array, not an array.
    We were comparing 100 to the stringified array reference, which never
    matches.  This is why testing every tag is good.

diff --git a/checks/changelog-file b/checks/changelog-file
index 890d6ab..f785a2d 100644
--- a/checks/changelog-file
+++ b/checks/changelog-file
@@ -311,8 +311,8 @@ if (@entries) {
     while ($changes =~ /(closes\s*(?:bug)?\#?\s?\d{6,})[^\w]/ig) {
 	tag "possible-missing-colon-in-closes", "$1" if $1;
     }
-    my @closes = $entry->Closes;
-    for my $bug (@closes) {
+    my $closes = $entry->Closes;
+    for my $bug (@$closes) {
         tag "improbable-bug-number-in-closes", $bug if ($bug < 100);
     }
 
diff --git a/debian/changelog b/debian/changelog
index 3544705..567780d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -19,6 +19,7 @@ lintian (2.2.6) UNRELEASED; urgency=low
     + [RA] Don't warn about uncompressed ChangeLog files in doc.  They may
       be small files and the maintainer may be installing some other
       upstream file as the upstrema changelog.  (Closes: #515601)
+    + [RA] Fix improbable-bug-number-in-closes so that it works.
   * checks/control-file:
     + [ADB] Properly exclude packages built from the glibc source package
       from the "hardcoded depends on libc" test.  (Closes: #515831)

-- 
Debian package checker


Reply to: