[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#512119: marked as done (False positives for update menus and bashism checks)



Your message dated Sat, 17 Jan 2009 21:47:04 +0000
with message-id <E1LOJ0S-0001lg-DY@ries.debian.org>
and subject line Bug#512119: fixed in lintian 2.1.6
has caused the Debian Bug report #512119,
regarding False positives for update menus and bashism checks
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
512119: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=512119
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: lintian
Version: 2.1.5

This output comes from running Lintian against some of my local
packaces, which aren't part of Debian but produce .deb files for
convenience.


I have this bit of code in a postinst:

  if type update-menus >/dev/null 2>&1; then
    update-menus
  fi

This produces two diagnostics from Lintian.

E: disobedience: maintainer-script-does-not-check-for-existence-of-updatemenus postinst:25
N:
N:   The maintainer script calls the update-menus command without checking
N:   for existence first. (The menu package which provides the command is
N:   not marked as `essential' package.)
N:
N:   For example, use the following code in your maintainer script:
N:    if [ -x /usr/bin/update-menus ] ; then update-menus ; fi
N:

Of course, I am checking for it, just not assuming anything about its
location.


W: disobedience: possible-bashism-in-maintainer-script postinst:24 'if type '
N:
N:   This script is marked as running under /bin/sh, but it seems to use a
N:   feature found in bash but not in the SUSv3 or POSIX shell
N:   specification.
N:
N:   Examples:
N:    '==' in a test, it should use '=' instead
N:    'read' without a variable in the argument
N:    'function' to define a function
N:    'source' instead of '.'
N: '. command args', passing arguments to commands via 'source' is not supported
N:    '{foo,bar}' instead of 'foo bar'
N:    '[[ test ]]' instead of '[ test ]' (requires a Korn shell)
N:
N:   Refer to Policy Manual, section 10.4 for details.
N:

In fact 'type' is listed in the SUS, so I think this warning is just
plain wrong.

http://www.opengroup.org/onlinepubs/009695399/utilities/type.html


Also a wishlist item:

W: disorder source: out-of-date-standards-version 3.7.2.2 (current is 3.8.0)
N:
N: The source package refers to a Standards-Version older than the one that
N:    was current at the time the package was created (according to the
N:    timestamp of the latest debian/changelog entry). Please consider
N:    updating the package to current Policy and setting this control field
N:    appropriately.
N:
N:    If the package is already compliant with the current standards, you
N: don't have to re-upload the package just to adjust the Standards-Version
N:    control field. However, please remember to update this field next time
N:    you upload the package.
N:
N:    Severity: normal; Certainty: certain
N:

What would be really handy here is a pointer to policy change history.


ttfn/rjk



--- End Message ---
--- Begin Message ---
Source: lintian
Source-Version: 2.1.6

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive:

lintian_2.1.6.dsc
  to pool/main/l/lintian/lintian_2.1.6.dsc
lintian_2.1.6.tar.gz
  to pool/main/l/lintian/lintian_2.1.6.tar.gz
lintian_2.1.6_all.deb
  to pool/main/l/lintian/lintian_2.1.6_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 512119@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Russ Allbery <rra@debian.org> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 17 Jan 2009 13:35:04 -0800
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.1.6
Distribution: unstable
Urgency: low
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Russ Allbery <rra@debian.org>
Description: 
 lintian    - Debian package checker
Closes: 315538 409099 464837 498668 501523 510957 511536 511859 512119
Changes: 
 lintian (2.1.6) unstable; urgency=low
 .
   * Summary of tag changes:
     + Added
       - diff-contains-cmake-cache-file
       - diff-contains-hg-tags-file
       - duplicate-uploader
       - empty-debian-diff
       - malformed-changes-file
       - missing-comma-after-substvar
       - source-contains-hg-tags-file
 .
   * checks/control-file{,.desc}:
     + [RA] Check for missing commas after substvars in dependency fields.
       Thanks, Jari Aalto.  (Closes: #409099)
   * checks/cruft{,.desc}:
     + [RA] Error on CMakeCache.txt files added or modified in the diff.
       Thanks, Joerg Jaspert.  (Closes: #510957)
     + [RA] Warn about .hgtags files in the diff and source.  Thanks,
       Holger Levsen and Chris Lamb.  (Closes: #464837)
     + [RA] Warn if the Debian diff or a non-native package is entirely
       empty.  (Closes: #498668)
   * checks/debhelper:
     + [RA] Ignore architecture when checking whether sufficient build
       dependencies are present for dh_* commands.  If the maintainer has
       architecture-restricted build dependencies, they presumably know
       what they're doing.  (Closes: #511859)
   * checks/fields{,.desc}:
     + [ADB] Warn about an individual uploader appearing multiple times
       in Uploaders.  Thanks, Joerg Jaspert.  (Closes: #511536)
     + [RA] Ignore architecture qualifications when checking for missing
       build dependencies.
   * checks/lintian.desc:
     + [RA] Add tag description for malformed-changes-file.
   * checks/menus:
     + [RA] Recognize type as a way of checking for binaries, even though
       it's a bashism, so that we don't issue confusing duplicate tags for
       one same problem.  (Closes: #512119)
   * checks/nmu{,.desc}:
     + [RA] Suppress NMU warnings for packages with "local" in the version
       number or "local package" in the first line of the changelog.
       Thanks, Zack Weinberg.  (Closes: #501523)
   * checks/scripts{,.desc}:
     + [RA] Mention type as a bashism and recommend which or command -v.
     + [RA] Recognize type as a way of checking for binaries, even though
       it's a bashism, so that we don't issue confusing duplicate tags for
       one same problem.
   * checks/standards-version.desc:
     + [RA] Add a pointer to the debian-policy upgrading-checklist.txt.gz
       in out-of-date-standards-version and ancient-standards-version.
 .
   * frontend/lintian:
     + [RA] Check that .changes files have at least a Format key.  If not,
       issue malformed-changes-file and skip them.  This catches .changes
       files that were PGP-signed twice.  (Closes: #315538)
 .
   * lib/Dep.pm:
     + [RA] New function, parse_noarch(), which ignores architecture
       qualifications when parsing a dependency field.
 .
   * t/runtests:
     + [RA] Add pre_upstream hook to modify the upstream source before
       generation of the .orig.tar.gz.
Checksums-Sha1: 
 642c0208e76677c71425e2e40b1bb9bc454d322a 1163 lintian_2.1.6.dsc
 9400f63412a8bc120a7343c5073aa2d68b87a0d9 585184 lintian_2.1.6.tar.gz
 2f4c3282ddc08ff8ec994370b8b82fd969ef385e 406112 lintian_2.1.6_all.deb
Checksums-Sha256: 
 139ba363bd20d22c65a80198beb3683634968f7b1c27f59fc1e5e1990d5d2362 1163 lintian_2.1.6.dsc
 362f1e7d3eaebfd17742d3e43efe9a55ee60ecfe1027ea8eb34d180adb618a4c 585184 lintian_2.1.6.tar.gz
 3f8bb7c5be9b0cda48dcc5ccd1ff35a6bbf22b0ebc883d056e52210a0033d8c6 406112 lintian_2.1.6_all.deb
Files: 
 b54092c52243a0bb22f557e119366763 1163 devel optional lintian_2.1.6.dsc
 7b2f4c36f87e5c1773a648a24e6b7e87 585184 devel optional lintian_2.1.6.tar.gz
 0414c5579a4d424796b1456bc501f993 406112 devel optional lintian_2.1.6_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAklyT4cACgkQ+YXjQAr8dHZM9gCdHGJVh2NwrYl7M6BjWBMA85qd
ilAAoKINBWH710B1olvfELJm1Y3MmT2q
=p/eY
-----END PGP SIGNATURE-----



--- End Message ---

Reply to: