[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#499074: [checks/patch-systems] depend on $(QUILT_STAMPFN), not patch



On Mon, Sep 15, 2008 at 05:18:07PM -0700, Russ Allbery wrote:
> Having a rule in debian/rules that depends on patch when using the quilt
> makefile fragment is almost always wrong, since patch is a phony target
> that will force any rule that depends on it to be rebuilt.  This often
> results in repeated compiles on the buildds, wasting resources.
> 
> Replacing the patch dependency with $(QUILT_STAMPFN) fixes this problem.
> 
> dpatch may have a similar issue; I haven't looked.

While I fully agree with this I would prefer to see this actually
documented in quilt.make before warning about it. Just so that we
know that the quilt maintainers agree with this assertion (and that
they see QUILT_STAMPFN as a public interface).

Gruesse,
-- 
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/



Reply to: