[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 1.24.4-110-g461090e



The following commit has been merged in the master branch:
commit 461090e2861e6f2d158a0aac92bf3e950390d28f
Author: Raphael Geissert <atomo64@gmail.com>
Date:   Thu Sep 4 14:23:54 2008 -0500

    checks/files: Check for Windows Development files in packages
    
    Ignore usr/share/doc because this are likely example files which
    might still be useful.
    
    Based on a patch by Raphael Geissert.

diff --git a/checks/files b/checks/files
index dc811af..78fa1d5 100644
--- a/checks/files
+++ b/checks/files
@@ -597,6 +597,12 @@ foreach my $file (sort keys %{$info->index}) {
 	    tag "script-with-language-extension", "$file";
 	}
 
+	# ---------------- Devel files for Windows
+	if ($file =~ m,/.+\.(vcproj|sln|dsp|dsw)(\.gz)?$,
+	    and $file !~ m,^usr/share/doc/,) {
+	    tag "windows-devel-file-in-package", "$file";
+	}
+
 	# ---------------- Autogenerated databases from other OSes
 	if ($file =~ m,/Thumbs\.db(\.gz)?$,i) {
 	    tag "windows-thumbnail-database-in-package", "$file";
diff --git a/checks/files.desc b/checks/files.desc
index 1f75a0e..2471e2e 100644
--- a/checks/files.desc
+++ b/checks/files.desc
@@ -1010,3 +1010,12 @@ Info: This package appears to contain an embedded copy of a PHP library.
  Please depend on the respective package providing the library and
  make sure it can be found by the scripts via the include_path.
 Ref: policy 4.13
+
+Tag: windows-devel-file-in-package
+Type: warning
+Severity: normal
+Certainty: possible
+Info: This package appears to contain development files only meaningful to
+ Windows environments.  Such files are generally useless in Debian packages and
+ were usually accidentally included by copying complete directories from the
+ source tarball.
diff --git a/debian/changelog b/debian/changelog
index c697c8b..368123f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -19,6 +19,7 @@ lintian (2.0.0~rc1) experimental; urgency=low
       - manpage-has-errors-from-pod2man
       - ored-build-depends-on-obsolete-package (actually a split of
          build-depends-on-obsolete-package in two tags)
+      - windows-devel-file-in-package
     + Removed:
       - package-needs-python-policy-debhelper
   
@@ -61,6 +62,8 @@ lintian (2.0.0~rc1) experimental; urgency=low
       exclusive list.  Also fix a spelling mistake.
     + [ADB] Re-add an accidentally removed slash to the check for embedded
       Javascript libraries, removing some false positives.  (Closes: #497215)
+    + [FL] Check for Windows Development files in packages.  Based on a patch
+      by Raphael Geissert.
   * checks/manpages{,.desc}:
     + [FL] Warn about the POD ERRORS sections pod2man generates.
       (Closes: #497864)
diff --git a/t/tests/6000_files-windows-devel-file-in-package.desc b/t/tests/6000_files-windows-devel-file-in-package.desc
new file mode 100644
index 0000000..7223100
--- /dev/null
+++ b/t/tests/6000_files-windows-devel-file-in-package.desc
@@ -0,0 +1,6 @@
+Testname: files-windows-devel-file-in-package
+Type: non-native
+Version: 1.0
+Description: Test tag windows-devel-file-in-package
+Test-Against: windows-devel-file-in-package
+Test-For: windows-devel-file-in-package
diff --git a/t/tests/files-windows-devel-file-in-package/debian/debian/examples b/t/tests/files-windows-devel-file-in-package/debian/debian/examples
new file mode 100644
index 0000000..18fb10f
--- /dev/null
+++ b/t/tests/files-windows-devel-file-in-package/debian/debian/examples
@@ -0,0 +1 @@
+foo.vcproj
diff --git a/t/tests/files-windows-devel-file-in-package/tags b/t/tests/files-windows-devel-file-in-package/tags
new file mode 100644
index 0000000..d8a4d52
--- /dev/null
+++ b/t/tests/files-windows-devel-file-in-package/tags
@@ -0,0 +1 @@
+W: files-windows-devel-file-in-package: windows-devel-file-in-package usr/lib/foo/foo.vcproj
diff --git a/t/tests/files-windows-devel-file-in-package/upstream/Makefile b/t/tests/files-windows-devel-file-in-package/upstream/Makefile
new file mode 100644
index 0000000..92f6a7c
--- /dev/null
+++ b/t/tests/files-windows-devel-file-in-package/upstream/Makefile
@@ -0,0 +1,8 @@
+default:
+	:
+
+install:
+	install -d $(DESTDIR)/usr/lib/foo
+	install -m644 foo.vcproj $(DESTDIR)/usr/lib/foo/foo.vcproj
+
+.PHONY: distclean realclean clean install test check
diff --git a/reporting/lintian-dummy.cfg b/t/tests/files-windows-devel-file-in-package/upstream/foo.vcproj
similarity index 100%
copy from reporting/lintian-dummy.cfg
copy to t/tests/files-windows-devel-file-in-package/upstream/foo.vcproj

-- 
Debian package checker


Reply to: