[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 1.24.4-83-g636a9c5



The following commit has been merged in the master branch:
commit 636a9c50a476ab5154120c18dc6adadee251a245
Author: Russ Allbery <rra@debian.org>
Date:   Sun Aug 31 21:38:10 2008 -0700

    Warn about closing an unlikely bug number
    
    * checks/changelog-file{,.desc}:
      + [RA] Warn about closing a bug number less than 100; this is likely
        a typo or placeholder.  Thanks, Raphael Gessiert.  (Closes: #497350)
    
    This will also catch the case of Closes: #0 in an ITP, since it will
    warn about the unlikely bug number.

diff --git a/checks/changelog-file b/checks/changelog-file
index f9cb2bd..c8c69e1 100644
--- a/checks/changelog-file
+++ b/checks/changelog-file
@@ -306,6 +306,10 @@ if (@entries) {
     while ($changes =~ /(closes\s*(?:bug)?\#?\s?\d{6,})[^\w]/ig) {
 	tag "possible-missing-colon-in-closes", "$1" if $1;
     }
+    my @closes = $entry->Closes;
+    for my $bug (@closes) {
+        tag "improbable-bug-number-in-closes", $bug if ($bug < 100);
+    }
 
     # Compare against NEWS.Debian if available.
     if ($news and $news->Version and $entry->Version eq $news->Version) {
diff --git a/checks/changelog-file.desc b/checks/changelog-file.desc
index 9658418..88d2f7f 100644
--- a/checks/changelog-file.desc
+++ b/checks/changelog-file.desc
@@ -218,6 +218,14 @@ Certainty: possible
 Info: While parsing the NEWS.Debian file, a syntax error was found.
 Ref: devref 6.3.4
 
+Tag: improbable-bug-number-in-closes
+Type: warning
+Severity: normal
+Certainty: possible
+Info: The most recent changelog closes a bug numbered less than 100.
+ While this is distantly possible, it's more likely a typo or a
+ placeholder value that mistakenly wasn't filled in.
+
 Tag: wrong-bug-number-in-closes
 Type: warning
 Severity: normal
diff --git a/debian/changelog b/debian/changelog
index 78718f2..4a7f26d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -8,6 +8,9 @@ lintian (2.0.0~rc1) experimental; urgency=low
   
   * checks/*.desc:
     + [ADB] Fix a number of spelling mistakes and typoes.
+  * checks/changelog-file{,.desc}:
+    + [RA] Warn about closing a bug number less than 100; this is likely
+      a typo or placeholder.  Thanks, Raphael Gessiert.  (Closes: #497350)
   * checks/debhelper{,.desc}:
     + [FL] Do not require versioned build-depends for compat level 5
       anymore.  Sarge is not supported anymore.  (Closes: #496826)

-- 
Debian package checker


Reply to: