[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: yet another patch



W: lintian-maint-cced-mail-sender :)

Frank Lichtenheld wrote:

> On Fri, Aug 29, 2008 at 09:37:17PM -0500, Raphael Geissert wrote:
>> Attached is a mbox for git-am making lintian check for embedded copies of
>> tinymce and tinymce2. I also made a change so the package names are used
>> as regexes to ease the case of tinymce where both packages provide the
>> same files but just different major versions.
> 
> I think it would be better in this case not to mark the right hand sides
> with qr'' unless they really are regexes. I doubt that it makes any real
> difference in this case and it obfuscates the patch.

It doesn't obfuscate the patch when using a smart (a.k.a wdiff-like) diff
viewer, but removed those anyway.


> 
> Gruesse,

Cheers,
-- 
Atomo64 - Raphael

Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html

Attachment: lintian_embedded-copies-of-js.mbox
Description: application/mbox


Reply to: