[SCM] Debian package checker branch, master, updated. 1.24.4-63-g9a292ff
The following commit has been merged in the master branch:
commit 9a292ff98547580f7af3649c5ae43d929073eb61
Author: Raphael Geissert <atomo64@gmail.com>
Date: Fri Aug 22 15:44:58 2008 -0500
Implement maintainer-also-in-uploaders
* checks/fields{,.desc}:
+ [RA] Check for a maintainer also listed in uploaders. Patch from
Raphael Geissert.
Signed-off-by: Raphael Geissert <atomo64@gmail.com>
diff --git a/checks/fields b/checks/fields
index dd1156d..d83e402 100644
--- a/checks/fields
+++ b/checks/fields
@@ -254,6 +254,12 @@ for my $f (qw(maintainer uploaders)) {
}
}
+if (defined $info->field('uploaders') && defined $info->field('maintainer')) {
+ my $maint = $info->field('maintainer');
+ tag 'maintainer-also-in-uploaders'
+ if $info->field('uploaders') =~ m/\Q$maint/;
+}
+
#---- Source
if ($type eq "source") {
diff --git a/checks/fields.desc b/checks/fields.desc
index 288e3cb..b0af1ea 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -974,3 +974,13 @@ Certainty: certain
Info: This package has a name suggesting that it contains detached
debugging symbols. If so, it should have priority "extra" since users
normally do not need such packages.
+
+Tag: maintainer-also-in-uploaders
+Type: warning
+Severity: minor
+Certainty: certain
+Info: The maintainer value also appears on the <tt>Uploaders</tt> field.
+ There were some reasons why this was useful when Uploaders support was
+ first introduced, but those have long-since been fixed and there is no
+ longer any need to list the maintainer in Uploaders. The duplicate
+ information should probably be removed.
diff --git a/debian/changelog b/debian/changelog
index c701577..27e2da7 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -6,6 +6,9 @@ lintian (1.25.0) unstable; urgency=low
The default output is unchanged, see the documentation on
how to utilize the new features.
+ * checks/fields{,.desc}:
+ + [RA] Check for a maintainer also listed in uploaders. Patch from
+ Raphael Geissert.
* checks/files:
+ [RA] Check for embedding copies of jsjac and jsMath. Patch from
Raphael Geissert.
diff --git a/testset/description/debian/control b/testset/description/debian/control
index 1ecf5a6..5def4b2 100644
--- a/testset/description/debian/control
+++ b/testset/description/debian/control
@@ -1,8 +1,8 @@
Source: description
Section: text
Priority: extra
-Maintainer: Lintian Maintainers <lintian-maint@debian.org>
-Uploaders: Tobias Toedter <toddy@debian.org>
+Maintainer: Tobias Toedter <toddy@debian.org>
+Uploaders: Tobias Toedter <toddy@debian.org>, Foo Bar Moo <foo@debian.org>
Standards-Version: 3.8.0
Package: description
diff --git a/testset/tags.description b/testset/tags.description
index 0d0c0fc..c0021c3 100644
--- a/testset/tags.description
+++ b/testset/tags.description
@@ -17,6 +17,7 @@ I: description-baz: no-md5sums-control-file
I: description-foo: no-md5sums-control-file
I: description-qux: no-md5sums-control-file
I: description: no-md5sums-control-file
+W: description source: maintainer-also-in-uploaders
W: description source: native-package-with-dash-version
W: description-bar: extended-description-line-too-long
W: description-foo: description-starts-with-leading-spaces
--
Debian package checker
Reply to: