--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: manpage wrapping warnings should be ignored if the line contains an URL
- From: Damyan Ivanov <dmn@debian.org>
- Date: Sun, 20 Jul 2008 19:46:27 +0300
- Message-id: <20080720164627.30775.17009.reportbug@pc1.creditreform.bg>
Package: lintian
Version: 1.24.2
Severity: normal
Tags: patch
Attached is a patch that makes checks/manpages not issue
manpage-has-errors-from-man if the line in question contains an URL.
We have a lot of packages that expose this warning and the current
practice is to add an override. However, I think it is a bug in lintian
and overriding it is not to be done.
Rationale:
First, breaking URLs is not that good. It does help users with narrow
terminals, but they have also the option of scrolling right and see the
whole URL and copy&paste it in parts (same as if it is broken to more
lines lines).
Yes, this would require that PAGER is set to less or another
scroll-capable pager, but given that less is Priority:standard, having
it installed and set as the default pager (less is preferred over other
'pager' alternatives) is how most systems are. The cases when PAGER is
set to 'more' are (I guess) in stripped-down systems that probably don't
have any manpages on them anyway.
We also considered the following alternatives to the patch:
* make pod2man not disable hyphenation.
There is a comment in the generated manpage saying that hyphenation is
disabled because it often doesn't work well with technical texts. This
is a bit questionable, I guess, and if you think this is a mistake,
please reassign the bug to 'perl'.
The rationale for not recommending such solution is that turning on
hyphenation (perhaps only for links, if such granularity is possible)
would benefit only narrow-terminal users in such a way that is equal
to scrolling (i.e. what they have now).
* patch upstream sources, hand-wrapping long URLs.
I feel discomfort sending such patches upstream. Additionally for not
improving much the situation for narrow-terminal users, it would be a
regression for users with wide terminals that now have to do two
copy&pastes regardless of the fact that their terminal is capable of
showing the complete URL unwrapped.
Thanks for considering,
dam
Debian Perl Group
-- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.25-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=bg_BG.UTF-8, LC_CTYPE=bg_BG.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages lintian depends on:
ii binutils 2.18.1~cvs20080103-7 The GNU assembler, linker and bina
ii diffstat 1.45-2 produces graph of changes introduc
ii dpkg-dev 1.14.20 Debian package development tools
ii file 4.25-1 Determines file type using "magic"
ii gettext 0.17-3 GNU Internationalization utilities
ii intltool-debian 0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii libdigest-sha-perl 5.47-1 Perl extension for SHA-1/224/256/3
ii libparse-debianchan 1.1.1-2 parse Debian changelogs and output
ii libtimedate-perl 1.1600-9 Time and date functions for Perl
ii liburi-perl 1.35.dfsg.1-1 Manipulates and accesses URI strin
ii man-db 2.5.2-2 on-line manual pager
ii perl [libdigest-sha 5.10.0-11.1 Larry Wall's Practical Extraction
lintian recommends no packages.
Versions of packages lintian suggests:
pn binutils-multiarch <none> (no description available)
ii libtext-template-perl 1.44-1.2 Text::Template perl module
ii man-db 2.5.2-2 on-line manual pager
-- no debconf information
diff --git a/checks/manpages b/checks/manpages
index ce0d4d0..93772fb 100644
--- a/checks/manpages
+++ b/checks/manpages
@@ -304,6 +304,9 @@ while (<IN>) {
next if /warning \[.*\]: cannot adjust line/;
next if /warning \[.*\]: can\'t break line/;
}
+ # ignore wrapping failures if they contain URLs
+ next if /:(\d+): warning \[.*\]: can\'t break line/
+ and $manfile[$1-1] =~ m,<(?:http|ftp)://.+>,i;
# ignore charset issues with old versions of man for all man pages
# since we can't know, with old versions, whether that was just a
# Unicode issue
--- End Message ---
--- Begin Message ---
Source: lintian
Source-Version: 1.24.4
We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive:
lintian_1.24.4.dsc
to pool/main/l/lintian/lintian_1.24.4.dsc
lintian_1.24.4.tar.gz
to pool/main/l/lintian/lintian_1.24.4.tar.gz
lintian_1.24.4_all.deb
to pool/main/l/lintian/lintian_1.24.4_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 491578@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Frank Lichtenheld <djpig@debian.org> (supplier of updated lintian package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Fri, 22 Aug 2008 07:43:52 +0200
Source: lintian
Binary: lintian
Architecture: source all
Version: 1.24.4
Distribution: unstable
Urgency: low
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Frank Lichtenheld <djpig@debian.org>
Description:
lintian - Debian package checker
Closes: 293296 491578 493660 494400 494450 494577 494723 494919 495153 495155
Changes:
lintian (1.24.4) unstable; urgency=low
.
The "[JP] is Jordà Polo" release.
.
* checks/*.desc:
+ [JP] Update, fix and unify various manual references.
* checks/copyright-file:
+ [ADB] Don't flag copyright files using phrases such as "previously
distributed under the GNU GPL" as lacking a reference to the license.
Thanks Raphael Geissert.
* checks/cruft{,.desc}:
+ [FL] Add new check for outdated libtool files.
(Closes: #293296)
+ [FL] Don't exclude all of lintian, but only files in the test suites.
* checks/files{,.desc}:
+ [ADB] Don't warn about embedded Javascript libraries in the package
that actually provides the library. Thanks Raphael Geissert for
pointing out the problem. (Closes: #494577)
+ [ADB] Enhance the description of package-contains-empty-directory to
mention how to remove such directories when building the package.
Thanks Chris Lamb. (Closes: #495153)
+ [ADB] Add libjs-yui (the Yahoo User Interface Library) to the list of
packages which contain Javascript libraries and should be depended upon
rather than embedded in other packages. Patch from Chris Lamb.
(Closes: #495155)
* checks/manpages:
+ [RA] Also ignore "cannot adjust line" errors from man for lines that
contain URLs. Thanks, Stéphane Glondu. (Closes: #491578)
* checks/scripts:
+ [ADB] Split the "read without variable or with invalid options" bashism
test in two, thus enabling the checks to be more accurate and avoiding
an uninitialized variable warning. (Closes: #494450)
+ [RA] Add dash to the recognized characters in a command in
command-with-path-in-maintainer-script to avoid truncation. Thanks,
Thijs Kinkhorst. (Closes: #494723)
+ [RA] Add jruby1.1, thanks Sebastien Delafond. (Closes: #494919)
* checks/shared-libs{,.desc}:
+ [RA] Clarify that shlibs-declares-dependency-on-other-package can be
issued for a version mismatch. (Closes: #494400)
+ [ADB] Correctly match alternative dependency templates in symbols
files which specify an unversioned dependency.
* checks/standards-version:
+ [FL] Avoid Perl warning if only the timestamp could not be parsed.
.
* collection/objdump-info:
+ [ADB] Correctly parse a readelf symbol version block containing the
definition of a single symbol.
.
* debian/rules:
+ [FL] Use $(PERL) instead of a hardcoded path.
+ [FL] Clean-up the binary-indep code.
+ [FL] Add build stamp file.
.
* doc/README{,.in}:
+ [FL] Move README to README.in and add the listing of lintian
options on build time from lintian --help.
.
* frontend/lintian:
+ [FL] Do not try to use fail() before the lintian libraries are
loaded.
+ [JP] Allow tags from the "lintian" checkset to be specified with --tags.
.
* lib/manual_refs:
+ [JP] Regenerate with new manual_refs_update.pl script.
(Closes: #493660)
* lib/Read_taginfo.pm, lib/Manual_refs.pm:
+ [JP] Add support for new manuals, allow specifying manual
sections by id and not only by section number.
+ [JP] Link manpages to manpages.debian.net.
.
* private/manual_refs_update.pl:
+ [JP] Add support for many more manuals (FHS, debconf-spec,
{menu,python,perl}-policy, libpkg-guide).
Checksums-Sha1:
0714001be77eebecc2f20bcd74098371f52114ef 1123 lintian_1.24.4.dsc
ab98c439b7a09b0366486a0f8bed58f400ec7aba 503283 lintian_1.24.4.tar.gz
9b8489185ad6138a0e7f79a6c8c196a2a5a77b5f 376638 lintian_1.24.4_all.deb
Checksums-Sha256:
1b0ab7ce03efb7bf5fdc670089d28685b9dad382622e97d2a54f3075b8a66f76 1123 lintian_1.24.4.dsc
38ba33d255d2319d380e5ec4939a659b6c4b9e32259908211a99be93e25be136 503283 lintian_1.24.4.tar.gz
590c391eff062ab14e613da045e0ae8bf9bc0f39e9ea07e75be840b50540ade1 376638 lintian_1.24.4_all.deb
Files:
10cf7747b903bc5f6360ff2bc7e1f722 1123 devel optional lintian_1.24.4.dsc
4c2321571809ba714fbb0ea4a46dccb6 503283 devel optional lintian_1.24.4.tar.gz
9e470528e8f9e3f7e5c7d60d519d3298 376638 devel optional lintian_1.24.4_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkiuYz0ACgkQQbn06FtxPfCjqgCbBnXhevTo+UssnO3J+GltzasN
yXcAnAk6DHVlMQGkjkDbGxyYfxfY3fhD
=M3nQ
-----END PGP SIGNATURE-----
--- End Message ---