[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#495176: lintian: false positive: incorrect handling of continuation lines in scripts



Package: lintian
Version: 1.24.2.1
Severity: normal

If you check out fakeroot-ng version 0.12-1 (I worked around this bug in
0.12-2), lintian complains about command with path in maintainer script,
line 37 of postinst.

If you look at the actual script, however, line 36 and onwards look like
this:
update-alternatives --install /usr/bin/fakeroot fakeroot \
            /usr/bin/fakeroot-ng 5 \
        --slave /usr/share/man/man1/fakeroot.1.gz \
            fakeroot.1.gz /usr/share/man/man1/fakeroot-ng.1.gz

While line 37 indeed starts with what looks like a command, and it
indeed has a path, but it is, in fact, an argument passed to
"update-alternatives".

In order to solve this, lintian needs to do a more complete parsing of
the lines before passing them on to the rules. I would suggest
concatanating all the lines that are continuation lines into one string,
and only then passing them on to the rules. This will have the side
effect that the rules will attribute any problem in the above example to
line 36, regardless of the line the problem actually happened on, but
that, I think, is an acceptable price to pay (and not much different
than other warnings).

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.25-2-686 (SMP w/2 CPU cores)
Locale: LANG=he_IL, LC_CTYPE=he_IL (charmap=ISO-8859-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages lintian depends on:
ii  binutils            2.18.1~cvs20080103-7 The GNU assembler, linker and bina
ii  diffstat            1.45-2               produces graph of changes introduc
ii  dpkg-dev            1.14.20              Debian package development tools
ii  file                4.25-1               Determines file type using "magic"
ii  gettext             0.17-3               GNU Internationalization utilities
ii  intltool-debian     0.35.0+20060710.1    Help i18n of RFC822 compliant conf
ii  libparse-debianchan 1.1.1-2              parse Debian changelogs and output
ii  libtimedate-perl    1.1600-9             Time and date functions for Perl
ii  liburi-perl         1.35.dfsg.1-1        Manipulates and accesses URI strin
ii  man-db              2.5.2-2              on-line manual pager
ii  perl [libdigest-sha 5.10.0-11.1          Larry Wall's Practical Extraction 

lintian recommends no packages.

Versions of packages lintian suggests:
pn  binutils-multiarch            <none>     (no description available)
pn  libtext-template-perl         <none>     (no description available)
ii  man-db                        2.5.2-2    on-line manual pager

-- no debconf information



Reply to: