Re: [SCM] Debian package checker branch, master, updated. 1.24.3-13-g38eaead
Frank Lichtenheld <djpig@debian.org> writes:
> On Mon, Aug 11, 2008 at 06:59:55PM +0000, Russ Allbery wrote:
>> diff --git a/checks/scripts b/checks/scripts
>> index 9abddc2..3e96b67 100644
>> --- a/checks/scripts
>> +++ b/checks/scripts
>> @@ -736,7 +736,7 @@ while (<SCRIPTS>) {
>> tag "maintainer-script-modifies-inetd-conf", "$file:$."
>> unless Dep::implies($deps{provides}, Dep::parse('inet-superserver'));
>> }
>> - if (m,^$LEADIN(/(usr/)?s?bin/\w+),) {
>> + if (m,^$LEADIN(/(usr/)?s?bin/[\w-]+),) {
>
> Why so conservative here? I feel that something like \S or [^`)}]
> would be better here.
I thought about that, but it "breaks" (in that the command will be wrong)
if people do something like /usr/bin/foo;bar (or || or | or something).
What we have now still misses . though, which is sometimes used in command
names.
I think what we really want is "all non-metacharacters", but basically the
question made my head hurt so I did something simple. :)
--
Russ Allbery (rra@debian.org) <http://www.eyrie.org/~eagle/>
Reply to: