[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#494577: Please add exemptions for "embedded-javascript-library" tag.



Package: lintian
Version: 1.24.3
Tags: patch

Hi,

(My own fault, but) I think lintian should have exemptions for package/file
pairs in the "embedded-javascript-library" tag.

The lack of this feature is currently causing ~10 false positives where the
"official" libraries that are providing the libraries are being tagged.

A patch is attached, but I'm not sure if it accomodates files that have a
version suffix, like "prototype-1.6.0.2.js".


Regards,

-- 
Chris Lamb, UK                                       chris@chris-lamb.co.uk
                                                            GPG: 0x634F9A20
commit ea98fd7d941bcd38150243e14b0c80cf2b2c009e
Author: Chris Lamb <chris@chris-lamb.co.uk>
Date:   Sun Aug 10 19:54:32 2008 +0100

    Add exemptions for "embedded-javascript-library" tag.
    
    Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>

diff --git a/checks/files b/checks/files
index de9c919..b88b07f 100644
--- a/checks/files
+++ b/checks/files
@@ -616,7 +616,32 @@ foreach my $file (sort keys %{$info->index}) {
 			 fckeditor|
 			 cropper(\.uncompressed)?
 			)\.js(\.gz)?$,ix) {
-	    tag "embedded-javascript-library", "$file";
+	    if (not {
+		'libjs-prototype' => {
+		    'usr/share/javascript/prototype/prototype-1.6.0.2.js' => 1,
+		},
+		'libjs-scriptaculous' => {
+		    'usr/share/javascript/scriptaculous/scriptaculous.js' => 1,
+		},
+		'fckeditor' => {
+		    'usr/share/fckeditor/fckeditor.js' => 1,
+		},
+		'libjs-jquery' => {
+		    'usr/share/javascript/jquery/jquery.lite.js' => 1,
+		    'usr/share/javascript/jquery/jquery.min.js' => 1,
+		    'usr/share/javascript/jquery/jquery.pack.js' => 1,
+		},
+		'libjs-cropper' => {
+		    'usr/share/javascript/cropper/cropper.js' => 1,
+		    'usr/share/javascript/cropper/cropper.uncompressed.js' => 1,
+		},
+		'libjs-mochikit' => {
+		    'usr/share/doc/libjs-mochikit/lib/MochiKit/MochiKit.js.gz' => 1,
+		    'usr/share/javascript/mochikit/MochiKit.js' => 1,
+		},
+	    }->{$pkg}{$file}) {
+		tag "embedded-javascript-library", "$file";
+	    }
 	}
 
 	# ---------------- embedded Feedparser library

Attachment: signature.asc
Description: PGP signature


Reply to: