[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: one more tag for watch-file



Raphael Geissert <atomo64+debian@gmail.com> writes:
> Raphael Geissert wrote:

>> Will adjust it to just emit the tag when a version was set.
>
> Done.

> --- a/checks/watch-file.desc
> +++ b/checks/watch-file.desc
> @@ -77,3 +77,8 @@ Info: The watch file seems to be passing arguments to the redirector
>   other than a path. Calling the SourceForge redirector with parameters like
>   <tt>project</tt> prevents uscan from generating working uri's to the files
>   and thus has been deprecated and is no longer supported by the redirector.
> +
> +Tag: debian-watch-file-contains-no-uris
> +Type: warning
> +Info: The watch file is present and specified a file version but does not
> + contain any URI to be checked.

I looked at this and it just doesn't feel right to me.  I tried to write
some advice in that tag about what the likely problem was, and couldn't
come up with any case where this was likely to happen except in the case
that sparked this thread, where the intention was to document that a watch
file wasn't appropriate.  In that case, what does it matter whether a
version was specified?  We'd be telling people to omit the version line as
well because that's what our check looks for, but I can't think of why it
should matter.

-- 
Russ Allbery (rra@debian.org)               <http://www.eyrie.org/~eagle/>


Reply to: