Bug#484549: lintian: Check that patches in debian/patches/ do not modify files in the debian directory
Package: lintian
Version: 1.23.49
Severity: wishlist
Usertags: 3.0-quilt-by-default
During my tests on the Debian archive, I have found several cases where (quilt)
patches in debian/patches/ do modify other files within the debian
sub-directory.
This is always wrong as the files in the debian directory are provided by
Debian.
Furthermore those packages do not work with the "3.0 (quilt)" source
format as it needs to generate a diff between the current source directory
and the upstream source + a copy of the debian directory + the patches
from the quilt series.
When we copy the debian directory, the patches are already applied (since
they are applied at extraction time) and when we try to reapply patches
it fails.
Thus it would be really nice if we could get such a check in the
not-too-distant future. I imagine that you can simply run
"diffstat -p0 -l <file>" on all debian/patches/* and analyze the
output. If it starts with m|^(\./)?debian/| or m|^(\./)?[^/]+/debian/|
then you complain. diffstat will silenty ignore files which are not
patches.
Cheers,
-- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.24-1-686 (SMP w/1 CPU core)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages lintian depends on:
ii binutils 2.18.1~cvs20080103-6 The GNU assembler, linker and bina
ii diffstat 1.45-2 produces graph of changes introduc
ii dpkg-dev 1.14.20 package building tools for Debian
ii file 4.24-2 Determines file type using "magic"
ii gettext 0.17-2 GNU Internationalization utilities
ii intltool-debian 0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii libparse-debianchan 1.1.1-2 parse Debian changelogs and output
ii liburi-perl 1.35.dfsg.1-1 Manipulates and accesses URI strin
ii man-db 2.5.2-1 on-line manual pager
ii perl [libdigest-sha 5.10.0-10 Larry Wall's Practical Extraction
lintian recommends no packages.
-- no debconf information
Reply to: