[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#471333: marked as done ([checks/scripts] script_is_evil_and_wrong() regex error)

Your message dated Sat, 29 Mar 2008 18:12:20 +0000
with message-id <1206814340.29915.23.camel@kaa.jungle.aubergine.my-net-space.net>
and subject line Re: Bug#471333: [checks/scripts] script_is_evil_and_wrong() regex error
has caused the Debian Bug report #471333,
regarding [checks/scripts] script_is_evil_and_wrong() regex error
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
471333: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=471333
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: lintian
Version: 1.23.47
Tags: patch

Hi,

script_is_evil_and_wrong fails to catch scripts using "${1:+$@}" as it
expects the optional quote to appear immediately before $@ rather than
before the optional ${1+.

The attached patch fixes this.

Regards,

Adam

Attachment: lintian-siew-quotes.diff
Description: Binary data


--- End Message ---
--- Begin Message --- 
On Mon, 2008-03-17 at 13:30 +0000, Adam D. Barratt wrote:
> Package: lintian
> Version: 1.23.47
> Tags: patch
> 
> Hi,
> 
> script_is_evil_and_wrong fails to catch scripts using "${1:+$@}" as it
> expects the optional quote to appear immediately before $@ rather than
> before the optional ${1+.
> 
> The attached patch fixes this.

Except all I did was trade one bug for another. *sigh*

The existing behaviour was perfectly reasonable, it just didn't catch
the case where the full expression was quoted. I've included that change
in the batch of patches I've sent to the list, so I'm going to close
this non-bug now.

Apologies for the noise.

Adam

--- End Message ---
Reply to: