Russ Allbery <rra@debian.org> writes: > he@debian.org writes: >> * check/patch-systems: >> + [HE] Warn if the .diff.gz contains changes while the package uses >> a patch system. (Closes: #452215) > Some people have argued on debian-devel that the correct way to use a > patch system is to apply all the patches in the clean target rather than > in the build target so that the source package is shipped with all the > patches applied. The rationale is that this allows someone preparing an > NMU to just ignore the patch system (at the cost of desynchronizing the > changes from the patch system for the maintainer). I have to admit that I did not follow that thread on -devel, somewhere after the 200th mail, I lost interest. > I don't know if we want to allow for that or not. I find the logic > dubious, but dpatch supports that mode of operation. I have to admit that I consider using a patch system in this way to be a bug. I think we might want to upload with this check and see if there are too many "false" positives. OTOH, what might be more important would be to introduce checks for other patch systems, but I fear I don't know enough about them to add some checks (especially after seeing how much I didn't know about dpatch...) Marc -- BOFH #179: multicasts on broken packets
Attachment:
pgpqLZPDfaubT.pgp
Description: PGP signature