[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

lintian: r1225 - in trunk: checks debian testset/binary/debian



Author: rra
Date: 2008-02-21 03:46:21 +0100 (Thu, 21 Feb 2008)
New Revision: 1225

Modified:
   trunk/checks/menu-format
   trunk/debian/changelog
   trunk/testset/binary/debian/menu
Log:
* checks/menu-format:
  + [RA] When the menu or desktop file invokes a quoted command via an
    su program, don't try to check whether the command is in the
    package.  Thanks, Paul Wise.  (Closes: #466665)

Modified: trunk/checks/menu-format
===================================================================
--- trunk/checks/menu-format	2008-02-20 18:04:17 UTC (rev 1224)
+++ trunk/checks/menu-format	2008-02-21 02:46:21 UTC (rev 1225)
@@ -891,7 +891,7 @@
     } else {
         $cmd = $com[0];
     }
-    my $okay = $cmd && ($file_index{$cmd} || grep { $file_index{$_ . $cmd} } @path);
+    my $okay = $cmd && ($cmd =~ /^[\'\"]/ || $file_index{$cmd} || grep { $file_index{$_ . $cmd} } @path);
     return ($okay, $cmd);
 }
 

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2008-02-20 18:04:17 UTC (rev 1224)
+++ trunk/debian/changelog	2008-02-21 02:46:21 UTC (rev 1225)
@@ -35,6 +35,10 @@
     + [RA] Mention in binary-without-manpage that if the man pages are
       provided by another package on which this package depends, a lintian
       override is appropriate.
+  * checks/menu-format:
+    + [RA] When the menu or desktop file invokes a quoted command via an
+      su program, don't try to check whether the command is in the
+      package.  Thanks, Paul Wise.  (Closes: #466665)
   * checks/scripts{.desc,}:
     + [FL] Warn if a maintainer script is a valid shell script but
       doesn't seem to have any actual code.  Based on an idea

Modified: trunk/testset/binary/debian/menu
===================================================================
--- trunk/testset/binary/debian/menu	2008-02-20 18:04:17 UTC (rev 1224)
+++ trunk/testset/binary/debian/menu	2008-02-21 02:46:21 UTC (rev 1225)
@@ -22,3 +22,4 @@
 ?package(binary):needs="wm" section="FVWM Modules" title="Fake Module" command="hello"
 ?package(binary):needs="fvwmmodule" section="Window Maker" title="Fake Module"\
  command="hello"
+?package(binary):needs="x11" section="Applications/System/Hardware" title="Run xfdisk" command="su-to-root -c 'xfdisk -f'"


Reply to: