[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: checks/scripts / checkbashsims updates



On Mon, 2008-02-18 at 16:33 -0800, Russ Allbery wrote:
> "Adam D. Barratt" <adam@adam-barratt.org.uk> writes:
[...]
> > The first issue is from the checkbashisms side:
> >
> > '(?<!\$)\(\(',               # '((' should be '$(('
> >
> > This will also match constructs such as "if ((foo || bar) && baz)". I've
> > tightened the expression in checkbashisms SVN to be '(?<!\$)\(\(.*\)\)'.
> 
> Done likewise in Subversion for lintian.

Sorry to be a pain, but we've tightened this further in svn to

	'(?<![\$\(])\(\(.*\)\)'

so as not to match constructs such as

	progress_size=$(((100 - $PROGRESS_STATE) / 3))

Adam


Reply to: