lintian: r1211 - in trunk: checks debian
Author: rra
Date: 2008-02-19 01:35:00 +0100 (Tue, 19 Feb 2008)
New Revision: 1211
Modified:
trunk/checks/scripts
trunk/debian/changelog
Log:
+ [RA] Update regexes based on checkbashisms to remove additional
false positives. Thanks, Adam D. Barratt.
Modified: trunk/checks/scripts
===================================================================
--- trunk/checks/scripts 2008-02-18 17:50:31 UTC (rev 1210)
+++ trunk/checks/scripts 2008-02-19 00:35:00 UTC (rev 1211)
@@ -561,13 +561,13 @@
'(?:^|\s+)echo\s+-e', # echo -e
'(?:^|\s+)exec\s+-[acl]', # exec -c/-l/-a name
'(?:^|\s+)let\s', # let ...
- '(?<!\$)\(\(', # '((' should be '$(('
+ '(?<!\$)\(\(.*\)\)', # '((' should be '$(('
'(\[|test)\s+-a', # test with unary -a (should be -e)
);
# since this test is ugly, I have to do it by itself
# detect source (.) trying to pass args to the command it runs
- if (not $found and m/^\s*(\.\s+[^\s]+\s+([^\s]+))/) {
+ if (not $found and m/^\s*(\.\s+[^\s;\`]+\s+([^\s]+))/) {
if ($2 =~ /^(\&|\||\d?>|<)/) {
# everything is ok
;
@@ -710,7 +710,7 @@
next if /^#/o;
next if /^$/o;
last if (++$i > 20);
- if (/(^\s*|\beval\s*\'|;)exec\s*.+\s*.?\$0.?\s*(--\s*)?(\${1:?\+)?.?\$(\@|\*)/o) {
+ if (/(^\s*|\beval\s*\'|;\s*)exec\s*.+\s*.?\$0.?\s*(--\s*)?(\${1:?\+)?.?\$(\@|\*)/o) {
$ret = 1;
last;
}
Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog 2008-02-18 17:50:31 UTC (rev 1210)
+++ trunk/debian/changelog 2008-02-19 00:35:00 UTC (rev 1211)
@@ -27,6 +27,8 @@
+ [FL] Warn if a maintainer script is a valid shell script but
doesn't seem to have any actual code. Based on an idea
by Justin Pryzby. (Closes: #410042)
+ + [RA] Update regexes based on checkbashisms to remove additional
+ false positives. Thanks, Adam D. Barratt.
* frontend/lintian:
+ [CW] Make the presence of an Ubuntu release name in the version number
Reply to: