[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#286842: lintian: Avoid false positives



On Wednesday 13 February 2008 20:00:44 you wrote:
> Felipe Sateler <fsateler@gmail.com> writes:
> > Package: lintian
> > Followup-For: Bug #286842
> >
> > Is this working correctly? Take this from the csound package I'm
> > preparing (not in the archive yet):
> >
> > Copyright notices:
> >
> >     Csound is copyright (c)
> >         1986-1992 by the Massachussetts Institute of Technology
> >         1991-2008 by Barry Vercoe, John ffitch and others.
> >
> >     CsoundAC (formerly CsoundVST) is copyright (c) 2001-2008 by Michael
> > Gogins.
> >
> >     The csound Manual is copyright (c):
> >         2003 by Kevin Conder
> >         2004-2005 by Michael Gogins
> >
> > This is causing lintian to warn about copyright-without-copyright-notice
>
> It doesn't like the interposed (and meaningless) (c) in the case where the
> copyright is split across multiple lines.  I'll try to make it better
> about recognizing this, but the second example in particular gets more and
> more annoying to detect as more punctuation and newlines are added.  It's
> much easier if the debian/copyright file just has the official legal
> copyright notices on lines by themselves.  The more work that goes into
> moving things around, adding punctuation and newlines, and whatnot, the
> harder it is to detect.
>
> In other words, better would be:
>
>     Copyright 2003 by Kevin Conder
>     Copyright 2004-2005 by Michael Gogins
>
> However, in general you want to copy the upstream notices verbatim, and I
> know that these two desires are in tension and upstreams use notices like
> you have above.  The cases above should be possible to adapt for.

What bothers me is that although I have a line "blah is copyright by joe", 
lintian is still complaining. After all, the different modules have different 
copyrights.
I see that the regex is not case insensitive and thus checks for Copyright but 
not copyright, which would have avoided the warnings in my case. Had I 
written "CsoundAC (formerly CsoundVST) is Copyright (c) 2001-2008 by Michael 
Gogins.", the warning would have not appeared.

For the other cases, can't perl be made to read more than one line per 
pattern?

-- 
Felipe Sateler

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: