lintian: r1186 - in trunk: checks debian testset testset/relations/debian
Author: rra
Date: 2008-02-08 04:32:50 +0100 (Fri, 08 Feb 2008)
New Revision: 1186
Modified:
trunk/checks/fields
trunk/checks/fields.desc
trunk/debian/changelog
trunk/testset/relations/debian/control
trunk/testset/tags.relations
Log:
* checks/fields:
+ [RA] Warn of build-dependencies on a Debian revision of -1. They
make backporting unnecessarily difficult. Thanks, Erich Schubert.
(Closes: #345487)
Modified: trunk/checks/fields
===================================================================
--- trunk/checks/fields 2008-02-08 03:15:15 UTC (rev 1185)
+++ trunk/checks/fields 2008-02-08 03:32:50 UTC (rev 1186)
@@ -660,7 +660,7 @@
}
tag "build-depends-on-build-essential", $field
- if ($d_pkg eq "build-essential");
+ if ($d_pkg eq "build-essential");
tag "depends-on-build-essential-package-without-using-version", "$d_pkg [$field: $part_d_orig]"
if ($known_build_essential{$d_pkg} && ! $d_version->[1]);
@@ -673,6 +673,9 @@
tag "build-depends-on-x-metapackage", "$field: $part_d_orig"
if ($known_x_metapackages{$d_pkg} && &$is_dep_field($field));
+ tag "build-depends-on-1-revision", "$field: $part_d_orig"
+ if ($d_version->[0] eq '>=' && $d_version->[1] =~ /-1$/ && &$is_dep_field($field));
+
tag "bad-relation", "$field: $part_d_orig"
if $rest;
}
Modified: trunk/checks/fields.desc
===================================================================
--- trunk/checks/fields.desc 2008-02-08 03:15:15 UTC (rev 1185)
+++ trunk/checks/fields.desc 2008-02-08 03:32:50 UTC (rev 1186)
@@ -557,6 +557,16 @@
in either Build-Depends or Build-Depends-Indep, but the build relations
imply each other and are therefore redundant.
+Tag: build-depends-on-1-revision
+Type: warning
+Info: The package declares a build dependency on a version of a package
+ with a -1 Debian revision such as "libfoo (>= 1.2-1)". Such a
+ dependency will not be satisfied by a backport of libfoo 1.2-1 and
+ therefore makes backporting unnecessarily difficult. Normally, the -1
+ version is unneeded and a dependency such as "libfoo (>= 1.2)" would
+ be sufficient. If there was an earlier -0.X version of libfoo that would
+ not satisfy the dependency, use "libfoo (>= 1.2-1~)" instead.
+
Tag: needlessly-depends-on-awk
Type: error
Info: The package seems to declare a relation on awk. awk is a virtual
Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog 2008-02-08 03:15:15 UTC (rev 1185)
+++ trunk/debian/changelog 2008-02-08 03:32:50 UTC (rev 1186)
@@ -3,6 +3,10 @@
* checks/binaries:
+ [RA] Make an architecture specification after perlapi optional.
Thanks, gregor herrmann. (Closes: #464626)
+ * checks/fields:
+ + [RA] Warn of build-dependencies on a Debian revision of -1. They
+ make backporting unnecessarily difficult. Thanks, Erich Schubert.
+ (Closes: #345487)
* checks/po-debconf:
+ [RA] Accept three-character language codes for po files. Thanks,
Patrick Winnertz and Eddy Petrișor. (Closes: #464511)
Modified: trunk/testset/relations/debian/control
===================================================================
--- trunk/testset/relations/debian/control 2008-02-08 03:15:15 UTC (rev 1185)
+++ trunk/testset/relations/debian/control 2008-02-08 03:32:50 UTC (rev 1186)
@@ -4,7 +4,7 @@
Build-Depends: mail-transport-agent, libc6-dev, findutils, foo (= 3) [!amd64 !i386], bar, arch-test1 [i386], arch-test2 [!i386], quilt (>= 0.40), perl
Build-Depends-Indep: make, bash, debmake, build-essential, baz (= 2.0),
car (>= 1.0), car (<= 2.0), caz (= 1.0) [amd64], caz (>= 2.0) [i386],
- caz (= 2.0) [powerpc], perl (>= 5.0), foo (<< 4) [!amd64 !i386]
+ caz (= 2.0) [powerpc], perl (>= 5.0), foo (<< 4) [!amd64 !i386], libfoo (>= 1.2-1)
Build-Conflicts: foo [amd64 i386], bar [alpha test], xlibs-dev, arch-test1 [powerpc], arch-test2 [!sparc]
Build-Conflicts-Indep: debmake [!powerpc]
Maintainer: Debian QA Group <packages@qa.debian.org>
Modified: trunk/testset/tags.relations
===================================================================
--- trunk/testset/tags.relations 2008-02-08 03:15:15 UTC (rev 1185)
+++ trunk/testset/tags.relations 2008-02-08 03:32:50 UTC (rev 1186)
@@ -32,6 +32,7 @@
I: relations source: build-depends-without-arch-dep mail-transport-agent
W: relations source: ancient-standards-version 3.1.1 (current is 3.7.3)
W: relations source: bad-homepage lintian.debian.org
+W: relations source: build-depends-on-1-revision build-depends-indep: libfoo (>= 1.2-1)
W: relations source: package-has-a-duplicate-build-relation foo (= 3) [!amd64 !i386], foo (<< 4) [!amd64 !i386]
W: relations source: package-has-a-duplicate-build-relation perl, perl (>= 5.0)
W: relations source: redundant-origin-field
Reply to: