[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#463476: marked as done ([checks/scripts] script_is_evil_and_wrong() could catch more scripts)

Your message dated Wed, 06 Feb 2008 06:47:04 +0000
with message-id <E1JMe3k-0006sj-FP@ries.debian.org>
and subject line Bug#463476: fixed in lintian 1.23.43
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message --- 
Package: lintian
Version: 1.23.42
Tags: patch
X-Debbugs-Cc: pkg-devscripts@teams.debian.net

On Wed, 2008-01-30 at 10:30 -0800, Russ Allbery wrote:
> Raphael Geissert <atomo64+debian@gmail.com> writes:
> 
> > This sounds more like a report against checkbashisms.
> > I guess it could try to detect these:
> 
> See script_is_evil_and_wrong() in lintian's check/scripts.

Whilst pinching^Wincorporating script_is_evil_and_wrong() in to
checkbashisms, I noticed that it doesn't catch the former of the two
cases below, due to the use of $* rather than $@. The attached patch
matches both versions.

        exec guile -s $0 $*
        !#
        
        exec rep "$0" "$@"
        !#;; Source file: sawfish-client.jl
        
Regards,

Adam

--- scripts.orig	2008-01-31 20:25:14.000000000 +0000
+++ scripts	2008-01-31 20:39:26.000000000 +0000
@@ -683,7 +683,7 @@
 	next if /^#/o;
 	next if /^$/o;
         last if (++$i > 20);
-        if (/(^\s*|\beval\s*\'|;)exec\s*.+\s*.?\$0.?\s*(--\s*)?(\${1:?\+)?.?\$\@/o) {
+        if (/(^\s*|\beval\s*\'|;)exec\s*.+\s*.?\$0.?\s*(--\s*)?(\${1:?\+)?.?\$(@|\*)/o) {
             $ret = 1;
             last;
         }

--- End Message ---
--- Begin Message --- 
Source: lintian
Source-Version: 1.23.43

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive:

lintian_1.23.43.dsc
  to pool/main/l/lintian/lintian_1.23.43.dsc
lintian_1.23.43.tar.gz
  to pool/main/l/lintian/lintian_1.23.43.tar.gz
lintian_1.23.43_all.deb
  to pool/main/l/lintian/lintian_1.23.43_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 463476@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Russ Allbery <rra@debian.org> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue, 05 Feb 2008 21:07:30 -0800
Source: lintian
Binary: lintian
Architecture: source all
Version: 1.23.43
Distribution: unstable
Urgency: low
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Russ Allbery <rra@debian.org>
Description: 
 lintian    - Debian package checker
Closes: 273309 377392 458164 458742 458785 459502 459509 459514 459787 459851 459871 460168 460347 460499 460625 460731 460964 460966 461350 461822 461823 461978 461982 462065 462456 462586 462601 462635 463028 463138 463142 463281 463476 464026
Changes: 
 lintian (1.23.43) unstable; urgency=low
 .
   The "37 bug fixes is enough for one release" release.
 .
   * checks/binaries{.desc,}:
     + [RA] Don't require objdump's errors on files with bad dynamic tables
       to start at the beginning of the line.  Patch from Chris Lamb.
       (Closes: #459509)
     + [RA] Warn for packages that have binaries requiring libc but which
       don't depend on libc.  Patch from Niko Tyni.  (Closes: #461350)
     + [RA] Remove check for libc5 binaries.  libc5 is long-gone.
     + [RA] Remove various dead tag descriptions we no longer issue.
     + [RA] Warn on packages that provide Perl modules but don't depend on
       perlapi-*.  Thanks, Niko Tyni.  (Closes: #463142)
     + [RA] Check files in /usr/lib/debug directories mirroring the main
       file system to verify they are detached debugging symbols and not
       full libraries or executables.  Thanks, Neil Williams and Niko
       Tyni.  (Closes: #462456)
   * checks/changelog-file:
     + [RA] Decode the changelog entry from UTF-8 before doing length
       checks.  Thanks, Cyril Brulebois.  (Closes: #461822)
     + [RA] Check for mismatches between the latest changelog and
       NEWS.Debian entries if they're for the same package version.
       Thanks, Cyril Brulebois.  (Closes: #461823)
   * checks/common_data.pm:
     + [RA] Add Bugs, Origin, and Breaks to known binary and udeb fields
       and Bugs to known source fields, matching current dpkg.  Thanks,
       Raphaël Hertzog.  (Closes: #459787)
   * checks/debhelper:
     + [RA] CDBS now defaults to a debhelper compatibility level of V5.
     + [FL] Update list of debhelper commands that modify maintainer
        scripts. Add dh_icons, dh_installudev, dh_pysupport, dh_pycentral
        and rename dh_installtexfonts to dh_installtex.
     + [RA] Add checks for versioned debhelper dependencies for dh_icons
       and dh_installifupdown.  Thanks, Evgeni Golov.  (Closes: #463028)
   * checks/fields{.desc,}:
     + [RA] The CDBS ant rules are in class, not rules.  Thanks, Cyril
       Brulebois.  (Closes: #460168)
     + [RA] Versioned Python dependencies satisfy a Python debian/rules
       requirement.  Add a separate tag for Python build dependencies to
       explain the dependency possibilities.  Ignore dh_python if
       debian/pyversion or a Python-Version control field are present.
       Thanks, Loïc Minier.  (Closes: #460625)
     + [RA] Check that -dbg packages depend on their base package.  Patch
       from Chris Lamb.  (Closes: #458785)
     + [RA] Check the value of Dm-Upload-Allowed.
     + [RA] Warn about packages with a list as the maintainer and no
       Uploaders.  Thanks, Sune Vuorela.  (Closes: #462635)
     + [RA] Remove the package-has-duplicate-relation test.  It gets
       relations with different version strictness in different levels of
       dependency wrong and what it gets right dpkg-gencontrol strips out.
   * checks/files{.desc,}:
     + [RA] In many of the long descriptions for symlink-related tags,
       mention that running dh_link will fix symlink problems.
     + [RA] Fix a long-standing error in the regex checking for *.desktop
       files in /usr/share/gnome/apps that caused the tag to never be
       issued.  Remove the check for /usr/share/applnk, since obsolete or
       not KDE appears to actively use it still.
     + [RA] Check for *.devhelp{2,} files not linked into devhelp's search
       path.  Based on a patch by Bradley Smith.  (Closes: #273309)
     + [RA] Warn about /etc/cron.{hourly,daily,weekly,monthly} scripts that
       won't be executed by run-parts because of periods in the name.
       Patch from Chris Lamb.  (Closes: #458742)
     + [RA] Warn of .gitignore files installed by the package.  Patch from
       Chris Lamb.  (Closes: #459502)
     + [RA] Warn of more language extensions on files in the user's path.
       Patch from Chris Lamb.  (Closes: #459514)
     + [RA] Remove the tag for empty Perl directories.  The underlying
       issue is fixed in Perl 5.10; there's no need to add code to
       debian/rules when 5.10 is landing soon.  (Closes: #463138)
   * checks/infofiles:
     + [RA] Don't issue unknown-intepreter for maintainer scripts with
       weird interpreters.  checks/scripts already handles this and the tag
       wasn't defined.  Thanks, Thijs Kinkhorst.  (Closes: #460964)
     + [RA] Fix Perl warnings given a zero-byte maintainer script.  Thanks,
       Thijs Kinkhorst.  (Closes: #460966)
   * checks/init.d{.desc,}:
     + [RA] Downgrade a missing LSB Short-Description keyword to info since
       it's not required for functionality.  Thanks, Petter Reinholdtsen.
       (Closes: #460499)
   * checks/manpages{.desc,}:
     + [RA] Make hyphen-used-as-minus-sign more conservative to avoid false
       positives with non-ASCII text and catch hyphens at the start of
       lines.  Thanks, Michal Čihař.  (Closes: #459871)
     + [CW] Use man's new --warnings option to catch use of undefined
       strings, macros, or diversions in manual pages, which usually indicate
       mistaken use of "." or "'" at the start of a line. This check is only
       enabled if man 2.5.1 or later is installed.  (Closes: #377392)
   * checks/menu-format:
     + [RA] Avoid a Perl warning for desktop entries without Exec.
     + [RA] Fix a bug that prevented Exec keys in desktop files from being
       checked at all.  Thanks, Raphael Geissert.  (Closes: #462601)
     + [RA] Exempt packages providing the su wrappers from the check for
       using su-to-root.  Thanks, Raphael Geissert.
   * checks/menus:
     + [RA] Don't issue unknown-interpreter for maintainer scripts with
       weird interpreters.
     + [RA] Fix Perl warnings given a zero-byte maintainer script.
   * checks/po-debconf:
     + [RA] Exclude from not-using-po-debconf template files with only the
       shared templates used for coordination with dictionaries-common.
       Thanks, Thomas Bushnell BSG.  (Closes: #460731)
   * checks/rules.desc:
     + [RA] To fix an ignores-make-clean-error, suggest removing "-" for
       static makefiles.  Thanks, Andrea Colangelo.  (Closes: #458164)
   * checks/scripts{.desc,}:
     + [RA] Re-add php4-cli as a valid interpreter for those who want to
       maintain stable compatibility.  Thanks, Thomas Goirand.
     + [RA] Be clearer in the tag name that php-cli dependencies should be
       versioned.  Add more explanation to the long description of several
       interpreter tags about limitations and requested bug filings.
     + [RA] Remove tcl as a valid interpreter since tclx8.3 is obsolete.
       (tclsh is the standard interpreter name.)
     + [RA] Require versioned dependencies for OCaml scripts.  Each version
       is ABI-incompatible.  Thanks, Samuel Mimram.  (Closes: #462065)
     + [RA] Add tcl and tk metapackages.  Thanks, Sergei Golovan.
       (Closes: #463281)
     + [RA] Catch exec wrappers that use $* instead of $@ (not that this is
       a good idea).  Thanks, Adam D. Barratt.  (Closes: #463476)
     + [RA] Integrate several more bashism checks from checkbashisms in
       devscripts.  Patch from Adam D. Barratt.  (Closes: #464026)
 .
   * debian/control:
     + [RA] Suggest man-db >= 2.5.1 for better warning support.
     + [RA] Wrap Uploaders.
 .
   * frontend/lintian:
     + [RA] Include info tags in the broken-down description of the
       override count since they're included in the total.  Based on a
       patch by Chris Lamb.  (Closes: #459851)
     + [RA] Don't try to report overrides when not checking a package.
       Thanks, Håkon Stordahl.  (Closes: #461978)
     + [RA] Cope with a relative path to the lab.  Patch from Håkon
       Stordahl.  (Closes: #461982)
     + [RA] Don't require *.changes files for source-only uploads to have a
       Description field.  Thanks, Cyril Brulebois.  (Closes: #462586)
 .
   * lib/Spelling.pm:
     + [RA] Add spelling corrections for PostgreSQL and OCaml and lots of
       new capitalization corrections.  (Closes: #460347)
Files: 
 d124d7752ccb9bd39612f0ab6920016d 904 devel optional lintian_1.23.43.dsc
 ad139b1091a3f8f9c80bcd021b89a48f 385135 devel optional lintian_1.23.43.tar.gz
 8779b8c012622fb9c5fa9305e190bb93 318858 devel optional lintian_1.23.43_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHqVGY+YXjQAr8dHYRArwaAJ42rDLMYNRdwBFM4XGk+gbEp2AF1gCeOv2y
Ahk4hHk45fRbAnjR3JA/KX0=
=OSLm
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: