[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

lintian: r1174 - in trunk: checks debian testset testset/binary/debian testset/foo++/debian testset/maintainer-scripts/debian



Author: rra
Date: 2008-02-05 02:56:49 +0100 (Tue, 05 Feb 2008)
New Revision: 1174

Modified:
   trunk/checks/fields
   trunk/checks/fields.desc
   trunk/debian/changelog
   trunk/testset/binary/debian/control
   trunk/testset/foo++/debian/control
   trunk/testset/maintainer-scripts/debian/control
   trunk/testset/tags.foo++
   trunk/testset/tags.maintainer-scripts
Log:
  + [RA] Check the value of Dm-Upload-Allowed.

Modified: trunk/checks/fields
===================================================================
--- trunk/checks/fields	2008-02-05 01:56:18 UTC (rev 1173)
+++ trunk/checks/fields	2008-02-05 01:56:49 UTC (rev 1174)
@@ -827,7 +827,8 @@
 
 	unfold('bugs', \$bugs);
 
-	tag "redundant-bugs-field", "" if $bugs =~ m{^\s*debbugs://bugs.debian.org/?\s*$}i;
+	tag "redundant-bugs-field"
+	    if $bugs =~ m,^\s*debbugs://bugs.debian.org/?\s*$,i;
 }
 
 #----- Python-Version
@@ -865,6 +866,19 @@
 	}
 }
 
+#----- Dm-Upload-Allowed
+
+if (open(FH, '<', 'fields/dm-upload-allowed')) {
+	my $dmupload = <FH>;
+	close FH;
+
+	unfold('dm-upload-allowed', \$dmupload);
+
+	unless ($dmupload =~ /^\s*yes\s*$/) {
+		tag "malformed-dm-upload-allowed", "$dmupload";
+	}
+}
+
 #----- Field checks (without checking the value)
 
 for my $field (glob("fields/*")) {

Modified: trunk/checks/fields.desc
===================================================================
--- trunk/checks/fields.desc	2008-02-05 01:56:18 UTC (rev 1173)
+++ trunk/checks/fields.desc	2008-02-05 01:56:49 UTC (rev 1174)
@@ -703,6 +703,14 @@
  versions, add a Python-Version control field (as described in 2.3 of the
  Python policy) to resolve this warning.
 
+Tag: malformed-dm-upload-allowed
+Type: error
+Ref: http://www.debian.org/vote/2007/vote_003
+Info: The Dm-Upload-Allowed field in this package is set to something
+ other than "yes".  The only standardized value for this field in the
+ Debian GR is "yes" and other values (including capitalization varients)
+ may not work as expected.
+
 Tag: doc-package-should-be-section-doc
 Type: warning
 Info: This package has a name suggesting that it contains only

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2008-02-05 01:56:18 UTC (rev 1173)
+++ trunk/debian/changelog	2008-02-05 01:56:49 UTC (rev 1174)
@@ -32,6 +32,7 @@
       Thanks, Loïc Minier.  (Closes: #460625)
     + [RA] Check that -dbg packages depend on their base package.  Patch
       from Chris Lamb.  (Closes: #458785)
+    + [RA] Check the value of Dm-Upload-Allowed.
   * checks/files{.desc,}:
     + [RA] In many of the long descriptions for symlink-related tags,
       mention that running dh_link will fix symlink problems.

Modified: trunk/testset/binary/debian/control
===================================================================
--- trunk/testset/binary/debian/control	2008-02-05 01:56:18 UTC (rev 1173)
+++ trunk/testset/binary/debian/control	2008-02-05 01:56:49 UTC (rev 1174)
@@ -7,6 +7,7 @@
 Homepage: http://lintian.debian.org/
 Vcs-Svn: http://svn.wolffelaar.nl/lintian/trunk
 XS-Vcs-Browser: http://svn.wolffelaar.nl/lintian/trunk
+XS-Dm-Upload-Allowed: yes
 
 Package: binary
 Architecture: any

Modified: trunk/testset/foo++/debian/control
===================================================================
--- trunk/testset/foo++/debian/control	2008-02-05 01:56:18 UTC (rev 1173)
+++ trunk/testset/foo++/debian/control	2008-02-05 01:56:49 UTC (rev 1174)
@@ -6,6 +6,7 @@
  Frank <djpig@debian.org>, Yama@gotchi, Josip,
  I am afraid of spam and think this helps <no_spam_please AT debian.org>
 Standards-Version: 3.1.1
+XS-Dm-Upload-Allowed: no
 
 Package: foo++
 Architecture: all

Modified: trunk/testset/maintainer-scripts/debian/control
===================================================================
--- trunk/testset/maintainer-scripts/debian/control	2008-02-05 01:56:18 UTC (rev 1173)
+++ trunk/testset/maintainer-scripts/debian/control	2008-02-05 01:56:49 UTC (rev 1174)
@@ -5,6 +5,7 @@
 Uploaders: Anyone but Jeroen <jeroen@wolffelaar.nl>
 Build-Depends: debhelper
 Standards-Version: 3.1.1
+XS-Dm-Upload-Allowed: Yes
 
 Package: maintainer-scripts
 Architecture: all

Modified: trunk/testset/tags.foo++
===================================================================
--- trunk/testset/tags.foo++	2008-02-05 01:56:18 UTC (rev 1173)
+++ trunk/testset/tags.foo++	2008-02-05 01:56:49 UTC (rev 1174)
@@ -1,5 +1,6 @@
 E: foo++ source: build-info-in-binary-control-file-section Package foo++
-E: foo++ source: debian-control-file-uses-obsolete-national-encoding at line 18
+E: foo++ source: debian-control-file-uses-obsolete-national-encoding at line 19
+E: foo++ source: malformed-dm-upload-allowed no
 E: foo++ source: uploader-address-is-on-localhost Jeroen van Wolffelaar<jeroen@localhost.localdomain>
 E: foo++ source: uploader-address-malformed I am afraid of spam and think this helps <no_spam_please AT debian.org>
 E: foo++ source: uploader-address-malformed Marc 'HE' Brockschmidt <he@unknown>

Modified: trunk/testset/tags.maintainer-scripts
===================================================================
--- trunk/testset/tags.maintainer-scripts	2008-02-05 01:56:18 UTC (rev 1173)
+++ trunk/testset/tags.maintainer-scripts	2008-02-05 01:56:49 UTC (rev 1174)
@@ -1,3 +1,4 @@
+E: maintainer-scripts source: malformed-dm-upload-allowed Yes
 E: maintainer-scripts source: orphaned-package-should-not-have-uploaders
 E: maintainer-scripts source: wrong-debian-qa-group-name QA group <packages@qa.debian.org>
 E: maintainer-scripts: control-file-has-bad-permissions config 0644 != 0755


Reply to: