[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

lintian: r1168 - in trunk: checks debian testset testset/manpages/debian



Author: rra
Date: 2008-02-04 05:24:27 +0100 (Mon, 04 Feb 2008)
New Revision: 1168

Modified:
   trunk/checks/files
   trunk/checks/files.desc
   trunk/debian/changelog
   trunk/testset/manpages/debian/overrides
   trunk/testset/tags.filenames
   trunk/testset/tags.manpages
Log:
  + [RA] Remove the tag for empty Perl directories.  The underlying
    issue is fixed in Perl 5.10; there's no need to add code to
    debian/rules when 5.10 is landing soon.  (Closes: #463138)

Modified: trunk/checks/files
===================================================================
--- trunk/checks/files	2008-02-04 04:10:37 UTC (rev 1167)
+++ trunk/checks/files	2008-02-04 04:24:27 UTC (rev 1168)
@@ -889,16 +889,15 @@
 # files generated by maintainer scripts).  Also skip base-files, which is a
 # very special case.
 #
-# Empty Perl directories are so common that we give them a different tag at a
-# lower severity level.
+# Empty Perl directories are an ExtUtils::MakeMaker artifact that will be
+# fixed in Perl 5.10, and people can cause more problems by trying to fix it,
+# so just ignore them.
 foreach my $dir (keys %dir_counts) {
     next if $dir eq "";
     next if ($dir =~ m{^var/} or $dir =~ m{^etc/});
     next if $pkg eq 'base-files';
     if ($dir_counts{$dir} == 0) {
-	if ($dir eq 'usr/lib/perl5/' or $dir eq 'usr/share/perl5/') {
-	    tag "package-contains-empty-perl-directory", $dir;
-	} else {
+	if ($dir ne 'usr/lib/perl5/' and $dir ne 'usr/share/perl5/') {
 	    tag "package-contains-empty-directory", $dir;
 	}
     }

Modified: trunk/checks/files.desc
===================================================================
--- trunk/checks/files.desc	2008-02-04 04:10:37 UTC (rev 1167)
+++ trunk/checks/files.desc	2008-02-04 04:24:27 UTC (rev 1168)
@@ -727,15 +727,6 @@
 Info: This package installs an empty directory.  This might be intentional
  but it's normally a mistake.  If it is intentional, add a lintian override.
 
-Tag: package-contains-empty-perl-directory
-Type: info
-Info: This package installs an empty /usr/lib/perl5 or /usr/share/perl5
- directory.  This is an artifact of ExtUtils::MakeMaker and isn't harmful,
- but it's messy.  It's preferrable to remove the directory the package
- doesn't use (/usr/share/perl5 for binary Perl modules and /usr/lib/perl5
- for pure Perl modules) in <tt>debian/rules</tt> after running make
- install.
-
 Tag: package-section-games-but-contains-no-game
 Type: error
 Ref: policy 11.11

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog	2008-02-04 04:10:37 UTC (rev 1167)
+++ trunk/debian/changelog	2008-02-04 04:24:27 UTC (rev 1168)
@@ -42,6 +42,9 @@
       Chris Lamb.  (Closes: #459502)
     + [RA] Warn of more language extensions on files in the user's path.
       Patch from Chris Lamb.  (Closes: #459514)
+    + [RA] Remove the tag for empty Perl directories.  The underlying
+      issue is fixed in Perl 5.10; there's no need to add code to
+      debian/rules when 5.10 is landing soon.  (Closes: #463138)
   * checks/infofiles:
     + [RA] Don't issue unknown-intepreter for maintainer scripts with
       weird interpreters.  checks/scripts already handles this and the tag

Modified: trunk/testset/manpages/debian/overrides
===================================================================
--- trunk/testset/manpages/debian/overrides	2008-02-04 04:10:37 UTC (rev 1167)
+++ trunk/testset/manpages/debian/overrides	2008-02-04 04:24:27 UTC (rev 1168)
@@ -9,4 +9,4 @@
 manpages:
 
 # An 'info' tag:
-package-contains-empty-perl-directory
+no-md5sums-control-file

Modified: trunk/testset/tags.filenames
===================================================================
--- trunk/testset/tags.filenames	2008-02-04 04:10:37 UTC (rev 1167)
+++ trunk/testset/tags.filenames	2008-02-04 04:24:27 UTC (rev 1168)
@@ -32,7 +32,6 @@
 I: filename-games: no-md5sums-control-file
 I: filenames: file-in-usr-something-x11-without-pre-depends usr/include/X11/
 I: filenames: no-md5sums-control-file
-I: filenames: package-contains-empty-perl-directory usr/share/perl5/
 I: more-filename-games: no-md5sums-control-file
 W: filename-games: binary-without-manpage usr/bin/test-game
 W: filename-games: no-priority-field

Modified: trunk/testset/tags.manpages
===================================================================
--- trunk/testset/tags.manpages	2008-02-04 04:10:37 UTC (rev 1167)
+++ trunk/testset/tags.manpages	2008-02-04 04:24:27 UTC (rev 1168)
@@ -37,7 +37,6 @@
 I: manpages: hyphen-used-as-minus-sign usr/share/man/man3/include.3.gz:13
 I: manpages: hyphen-used-as-minus-sign usr/share/man/man3/include.3.gz:14
 I: manpages: hyphen-used-as-minus-sign usr/share/man/man3/include.3.gz:9
-I: manpages: no-md5sums-control-file
 I: manpages: unused-override foo-tag-that-does-not-exist
 N: 2 tags overridden (1 error, 1 info)
 W: manpages source: ancient-standards-version 3.2.1 (current is 3.7.3)


Reply to: