lintian: r1156 - in trunk: checks debian testset testset/scripts testset/scripts/debian
Author: rra
Date: 2008-02-03 21:07:42 +0100 (Sun, 03 Feb 2008)
New Revision: 1156
Added:
trunk/testset/scripts/guile-bizarre
Modified:
trunk/checks/scripts
trunk/debian/changelog
trunk/testset/scripts/debian/rules
trunk/testset/tags.scripts
Log:
+ [RA] Catch exec wrappers that use $* instead of $@ (not that this is
a good idea). Thanks, Adam D. Barratt. (Closes: #463476)
Modified: trunk/checks/scripts
===================================================================
--- trunk/checks/scripts 2008-02-03 20:06:03 UTC (rev 1155)
+++ trunk/checks/scripts 2008-02-03 20:07:42 UTC (rev 1156)
@@ -685,7 +685,7 @@
next if /^#/o;
next if /^$/o;
last if (++$i > 20);
- if (/(^\s*|\beval\s*\'|;)exec\s*.+\s*.?\$0.?\s*(--\s*)?(\${1:?\+)?.?\$\@/o) {
+ if (/(^\s*|\beval\s*\'|;)exec\s*.+\s*.?\$0.?\s*(--\s*)?(\${1:?\+)?.?\$(\@|\*)/o) {
$ret = 1;
last;
}
Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog 2008-02-03 20:06:03 UTC (rev 1155)
+++ trunk/debian/changelog 2008-02-03 20:07:42 UTC (rev 1156)
@@ -58,6 +58,8 @@
is ABI-incompatible. Thanks, Samuel Mimram. (Closes: #462065)
+ [RA] Add tcl and tk metapackages. Thanks, Sergei Golovan.
(Closes: #463281)
+ + [RA] Catch exec wrappers that use $* instead of $@ (not that this is
+ a good idea). Thanks, Adam D. Barratt. (Closes: #463476)
* frontend/lintian:
+ [RA] Include info tags in the broken-down description of the
Modified: trunk/testset/scripts/debian/rules
===================================================================
--- trunk/testset/scripts/debian/rules 2008-02-03 20:06:03 UTC (rev 1155)
+++ trunk/testset/scripts/debian/rules 2008-02-03 20:07:42 UTC (rev 1156)
@@ -42,6 +42,7 @@
install -m 755 perl-bizarre-1 $(tmp)/usr/bin/
install -m 750 perl-bizarre-2 $(tmp)/usr/bin/
install -m 754 perl-bizarre-3 $(tmp)/usr/bin/
+ install -m 705 guile-bizarre $(tmp)/usr/bin/
# First one should produce a warning; second one shouldn't.
install -m 755 gccbug.dpatch $(tmp)/usr/share/scripts/
Added: trunk/testset/scripts/guile-bizarre
===================================================================
--- trunk/testset/scripts/guile-bizarre (rev 0)
+++ trunk/testset/scripts/guile-bizarre 2008-02-03 20:07:42 UTC (rev 1156)
@@ -0,0 +1,6 @@
+#! /bin/sh
+# -*- scheme -*-
+exec guile -s $0 $*
+# Seen in the wild as build-guile-gtk in libguilegtk-1.2-dev (0.31-5.1)
+# Tests script_is_evil_and_wrong
+!#
Modified: trunk/testset/tags.scripts
===================================================================
--- trunk/testset/tags.scripts 2008-02-03 20:06:03 UTC (rev 1155)
+++ trunk/testset/tags.scripts 2008-02-03 20:07:42 UTC (rev 1156)
@@ -29,6 +29,7 @@
W: scripts source: source-nmu-has-incorrect-version-number 6
W: scripts source: uses-dh-python-with-no-pycompat
W: scripts: binary-without-manpage usr/bin/envfoo
+W: scripts: binary-without-manpage usr/bin/guile-bizarre
W: scripts: binary-without-manpage usr/bin/jruby-broken
W: scripts: binary-without-manpage usr/bin/lefty-foo
W: scripts: binary-without-manpage usr/bin/make-foo
@@ -45,6 +46,7 @@
W: scripts: binary-without-manpage usr/bin/test.sh
W: scripts: binary-without-manpage usr/bin/tkfoo
W: scripts: binary-without-manpage usr/bin/wishfoo
+W: scripts: executable-is-not-world-readable usr/bin/guile-bizarre 0705 != 0755
W: scripts: executable-is-not-world-readable usr/bin/perl-bizarre-2 0750 != 0755
W: scripts: executable-is-not-world-readable usr/bin/suidperlfoo2 4751
W: scripts: executable-not-elf-or-script ./usr/bin/perl-bizarre-3
Reply to: