Re: RFC: [PATCH] Make "lintian --info --color=auto" work again
On Sat, Nov 29, 2008 at 03:32:26PM +0000, Adam D. Barratt wrote:
> The attached patch replaces the pipe from the main lintian script to
> lintian-info with an extra flag to Lintian::Output::print_tag()
> indicating whether the full output should be displayed. This allows
> "lintian --info --color=auto" to produce colourised output when being
> output to a terminal.
>
> Comments welcome.
While I don't doubt that your patch accomplishes it goal, I wonder
whether it would be better to fix this "correctly" now. By this
I mean:
1) The extended description should be available in the $tag_info
2) The list of already issued tags should probably be a object
attribute instead of a module attribute.
3) I'm unsure whether the flag show_description shouldn't be an
object attribute of Lintian::Output instead of a module
attribute of Tags.
Gruesse,
--
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/
Reply to: