On Sat, 29 Nov 2008 14:01:42 +0000, Adam D. Barratt wrote:
> [define %default_colors before creating the $GLOBAL output object]
> That looks "obviously correct" to me; thanks.
Cool, thanks.
> > - --colors=auto still fails because $self->stdout gets changed from
> > \*STDOUT to \*::OUTPUT_PIPE somewhere and therefore _do_color returns false.
> > Unfortunately I have no idea where/how this happens ...
> I'm guessing you're calling lintian with "-i"?
Indeed, sorry for not mentioning (and not testing without).
> If so, that's because the
> extra output is generated by piping lintian's output to lintian-info,
> which now causes the colour to be disabled when using "auto".
I see.
(And I was looking for OUTPUT_PIPE only in
/usr/share/lintian/lib/Lintian ...)
> I'm looking at a patch that makes lintian able to generate the output
> itself, thus allowing the combination of -i and --color=auto to work
> again (and will post it to the list for review once I've done some more
> testing).
Great, much appreciated.
Cheers,
gregor
--
.''`. Home: http://info.comodo.priv.at/{,blog/} / GPG Key ID: 0x00F3CFE4
: :' : Debian GNU/Linux user, admin, & developer - http://www.debian.org/
`. `' Member of VIBE!AT, SPI Inc., fellow of FSFE | http://got.to/quote/
`- NP: Flying Pickets: Sign Your Name
Attachment:
signature.asc
Description: Digital signature