Re: Fix and improve reference links (was: GSoC status: classification, output format and more)
Some comments regarding your patches:
On Wed, Aug 06, 2008 at 10:41:40PM +0200, Jordà Polo wrote:
> +my $ddoc_title = '<title>(.+?)<\/title>';
> +my $ddoc_ref = '<a href="(.+?)">([A-Z]|[A-Z]?[\d\.]+?)\.?\s+'.
> + '([\w\s[:punct:]]+?)<\/a>';
> +my @ddoc_fields = [ [ 'url' ], [ 'section' ], [ 'title' ] ];
Assigning a array-ref to an array makes no sense.
(I know that a807e791640f2e244bde757ea514e19b94886c96 changes
that again. But the issue persists).
Even though it might still do what you want, it looks just wrong.
Please change it to be consistent. (probably just by renaming
the variable to $ddoc_fields).
All regexes should be declared as such with qr//
> + 'http://www.pathname.com/fhs/pub/fhs-2.3.html',
> + '<title\s?>(.+?)<\/title\s?>',
> + '<a\s+href="(#.+?)"\s?>([\w\s[:punct:]]+?)<\/a\s?>',
> + [ [ 'section', 'url' ], [ 'title'] ] ],
If you use \s? I see no reason not to use \s* instead.
(Or maybe even \s*+ just to make backports to etch more painful ;))
>
> -my %refs;
> +# Collect all possible references from avilable manuals.
Typo avilable -> available
> + # Read until there are 2 newlines. This hack is needed since some lines in
> + # the Developer's Reference are cut in the middle of <a>...</a>.
> + local $/ = '\n\n';
Huh, is that really "\\n\\n" there? Not "\n\n"?
> while(<REFS>) {
> chomp;
> - next if m/^\s*\#/;
> + next if not m/^(.+?)::(.*?)::(.+?)::(.+?)$/;
>
> - my ($key, $data) = split;
> - $url{$key} = $data;
> + my ($man, $section, $title, $u) = split(::);
split('::')
Gruesse,
--
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/
Reply to: