[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 1.24.2-14-g941101c



The following commit has been merged in the master branch:
commit 5d3fbdad80b80c5053cfe77baa437d77a620ddd3
Author: Russ Allbery <rra@debian.org>
Date:   Sun Jul 20 22:32:16 2008 -0700

    Warn about packages depending exclusively on makedev
    
    * checks/fields{,.desc}:
      + [RA] Warn about packages that depend exclusively on makedev.
        Thanks, Josh Triplett.  (Closes: #491625)

diff --git a/checks/fields b/checks/fields
index dc72f16..77dbd19 100644
--- a/checks/fields
+++ b/checks/fields
@@ -529,6 +529,9 @@ if (($type eq "binary") || ($type eq 'udeb')) {
 					tag "old-versioned-python-dependency", "$field: $part_d_orig"
 					    if ($d_pkg eq 'python' && $d_version->[0] eq '<<' && &$is_dep_field($field)
 						&& $arch_indep && $pkg =~ /^python-/ && ! -f "fields/python-version");
+
+					tag "depends-exclusively-on-makedev", "$field",
+					    if ($field eq 'depends' && $d_pkg eq 'makedev' && @alternatives == 1);
 				}
 
 				for my $pkg (@seen_obsolete_packages) {
diff --git a/checks/fields.desc b/checks/fields.desc
index e5ab4eb..a0fa3fd 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -621,6 +621,14 @@ Info: The python-minimal package (and versioned variants thereof) exists
  becomes Essential, there is no need to depend on it, and until then,
  packages that require Python must depend on python.
 
+Tag: depends-exclusively-on-makedev
+Type: warning
+Info: This package depends on makedev without a udev alternative.  This
+ probably means that it doesn't have udev rules and relies on makedev to
+ create devices, which won't work if udev is installed and running.
+ Alternatively, it may mean that there are udev rules, but udev was not
+ added as an alternative to the makedev dependency.
+
 Tag: dbg-package-missing-depends
 Type: warning
 Info: This package has a name of the form of "X-dbg", indicating it
diff --git a/debian/changelog b/debian/changelog
index e8579c3..44ad4a8 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -16,6 +16,9 @@ lintian (1.24.3) unstable; urgency=low
   * checks/description:
     + [RA] Don't warn about a synopsis that ends in "etc."  Patch from
       Chris Lamb.  (Closes: #491252)
+  * checks/fields{,.desc}:
+    + [RA] Warn about packages that depend exclusively on makedev.
+      Thanks, Josh Triplett.  (Closes: #491625)
   * checks/patch-systems:
     + [RA] Combine all patch-system-but-direct-changes-in-diff instances
       into a single message to reduce the noise from packages that rebuild
diff --git a/testset/relations/debian/control b/testset/relations/debian/control
index 81c05e2..a33df41 100644
--- a/testset/relations/debian/control
+++ b/testset/relations/debian/control
@@ -17,7 +17,7 @@ Package: relations
 Architecture: all
 Section: contrib/misc
 Pre-Depends: awk|gawk
-Depends: relations(<< 3), dpkg, bash (>> 2.0 ), mail-transport-agent, gawk | awk, foo (>> 2.0), foo (<< 2.2), coreutils, ,null (>= 0), ${misc:Depends}
+Depends: relations(<< 3), dpkg, bash (>> 2.0 ), mail-transport-agent, gawk | awk, foo (>> 2.0), foo (<< 2.2), coreutils, ,null (>= 0), ${misc:Depends}, makedev
 Provides: mail-reader
 Replaces: relations
 Conflicts: foobar (<< 5&5), foo, relations,
@@ -34,9 +34,9 @@ Description: Strange dependency relationships
 Package: relations-multiple-libs
 Architecture: all
 Section: non-free/misc
-Depends: libstdc++2.10, libstdc++2.10-glibc2.2, libstdc++3.0, tk8.2, tk8.3, tcl8.0, tcl8.2, tkx8.2, tkx8.3, tclx8.2, libpng2, libpng3, xorg, ${shlibs:Depends}
+Depends: libstdc++2.10, libstdc++2.10-glibc2.2, libstdc++3.0, tk8.2, tk8.3, tcl8.0, tcl8.2, tkx8.2, tkx8.3, tclx8.2, libpng2, libpng3, xorg, ${shlibs:Depends}, makedev | udev
 Provides: awk
-Recommends: ${shlibs:Depends}, relations-multiple-libs, gs | gs-gpl
+Recommends: ${shlibs:Depends}, relations-multiple-libs, gs | gs-gpl, makedev
 Breaks: libpng3 (<< 1.0), libpng2
 Suggests: x-dev, ghostscript | gs
 Description: Duplicate library dependency relationships.
diff --git a/testset/tags.relations b/testset/tags.relations
index 78aefeb..10b9470 100644
--- a/testset/tags.relations
+++ b/testset/tags.relations
@@ -60,6 +60,7 @@ W: relations-multiple-libs: package-uses-breaks
 W: relations-multiple-libs: redundant-bugs-field
 W: relations-multiple-libs: redundant-origin-field
 W: relations: bad-homepage lintian.debian.org
+W: relations: depends-exclusively-on-makedev depends
 W: relations: depends-on-old-emacs recommends: emacs21
 W: relations: package-relation-with-self depends: relations (<< 3)
 W: relations: package-relation-with-self replaces: relations

-- 
Debian package checker


Reply to: