[SCM] Debian package checker branch, master, updated. 3ba555a321727666d95d6235bf3cf0f4c37a00cf
The following commit has been merged in the master branch:
commit 3ba555a321727666d95d6235bf3cf0f4c37a00cf
Author: Adam D. Barratt <adam@adam-barratt.org.uk>
Date: Thu Jul 10 21:48:42 2008 +0100
Fix a false positive in the check for the "function" bashism (Closes: #490227)
bash doesn't require the parentheses after the function name when "function" is used
diff --git a/checks/scripts b/checks/scripts
index ca1c52c..946cdb2 100644
--- a/checks/scripts
+++ b/checks/scripts
@@ -572,7 +572,7 @@ while (<SCRIPTS>) {
# unsafe echo with backslashes
);
my @bashism_regexs = (
- qr'function \w+\(\s*\)', # function is useless
+ qr'(?:^|\s+)function \w+(\s|\(|\Z)', # function is useless
# should be '.', not 'source'
$LEADIN . qr'source\s+(?:\.\/|\/|\$)[^\s]+',
qr'(test|-o|-a)\s*[^\s]+\s+==\s', # should be 'b = a'
diff --git a/debian/changelog b/debian/changelog
index c9512f8..1f5e7c2 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -60,7 +60,7 @@ lintian (1.24.2) unstable; urgency=low
+ [FL] Improve script_is_evil_and_wrong() to catch more scripts.
Patch by Adam D. Barratt.
+ [ADB] Update bashism regexes to add new checks, improve performance
- and reduce false positives.
+ and reduce false positives. (Closes: #490227)
* checks/shared-libs{,.desc}:
+ [ADB] Implement syntax and sanity checking for symbols files
(Closes: #452216)
--
Debian package checker
Reply to: