Re: lintian: r1393 - in trunk/reporting: . templates
On Wed, Jun 18, 2008 at 11:48:42PM +0200, djpig@debian.org wrote:
> Log:
> * reporting/templates/tag.tmpl:
> + Mark overridden tags.
The "O" for overridden is probably not as clear as E/W/I (the color
doesn't help either); it wouldn't hurt to mark it more explicitly, at
least for fully-overridden tags/packages.
I'm still not sure what's the best way to do it, but I think the
attached patch is an improvement[1]. Note that the "overridden" text has
been moved to the end of the line, but it should work if you prefer to
keep it where it is now.
1. http://ettin.org/tmp/ldo-mockup/overridden.png
diff --git a/reporting/lintian.css b/reporting/lintian.css
index 96b60e6..c5acb79 100644
--- a/reporting/lintian.css
+++ b/reporting/lintian.css
@@ -277,6 +277,17 @@ h2.tag a {
font-weight: bold;
}
+h2.tag span.type-O {
+ margin: 0 3px 0 0;
+ padding: 2px 4px;
+ color: #555;
+ background: #EEE;
+ font-family: monospace;
+ font-size: 1.1em;
+ font-weight: bold;
+ border: 1px solid #DDD;
+}
+
/* E/W/I colors */
span.type-I {
diff --git a/reporting/templates/tag.tmpl b/reporting/templates/tag.tmpl
index 7149180..e9b4f84 100644
--- a/reporting/templates/tag.tmpl
+++ b/reporting/templates/tag.tmpl
@@ -25,9 +25,9 @@
if (!$last
or "$info->{package} $info->{type}" ne "$last->{package} $last->{type}") {
if ($last) {
- my $overridden = $has_nonoverridden ? '' : qq{<span class="type-O">O</span> };
- $OUT .= qq( <h2 class="tag">$overridden<a href="../full/$last->{xref}">);
- $OUT .= "$last->{package}</a> ($last->{type})</h2>\n";
+ my $overridden = $has_nonoverridden ? '' : qq{ <span class="type-O">overridden</span>};
+ $OUT .= qq( <h2 class="tag"><a href="../full/$last->{xref}">);
+ $OUT .= "$last->{package}</a> ($last->{type})$overridden</h2>\n";
$OUT .= qq( <ul class="tag">\n);
$OUT .= $tag;
$OUT .= "</ul>\n";
@@ -43,9 +43,9 @@
$tag .= "$info->{extra}</li>\n";
}
}
- my $overridden = $has_nonoverridden ? '' : qq{<span class="type-O">O</span> };
- $OUT .= qq( <h2 class="tag">$overridden<a href="../full/$last->{xref}">);
- $OUT .= "$last->{package}</a> ($last->{type})</h2>\n";
+ my $overridden = $has_nonoverridden ? '' : qq{ <span class="type-O">overridden</span>};
+ $OUT .= qq( <h2 class="tag"><a href="../full/$last->{xref}">);
+ $OUT .= "$last->{package}</a> ($last->{type})$overridden</h2>\n";
$OUT .= qq( <ul class="tag">\n);
$OUT .= $tag;
$OUT .= "</ul>\n";
Reply to: