[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 442b6d69cd736082499e9ebb39c1f40d2f3e46d2



The following commit has been merged in the master branch:
commit 442b6d69cd736082499e9ebb39c1f40d2f3e46d2
Author: Adam D. Barratt <adam@adam-barratt.org.uk>
Date:   Sun Jul 6 22:08:25 2008 +0100

    Fix false-positives in the "echo with backslashes" bashism checks

diff --git a/checks/scripts b/checks/scripts
index fe7ca5f..799da1e 100644
--- a/checks/scripts
+++ b/checks/scripts
@@ -545,7 +545,7 @@ while (<SCRIPTS>) {
 		my $match = '';
 		my $LEADIN = qr'(?:(^|[`&;(|{])\s*|(if|then|do|while)\s+)';
 		my @bashism_single_quote_regexs = (
-		  $LEADIN . qr'echo\s+(?:-[^e]+\s+)?([\'])[^\']*(\\[\\abcEfnrtv0])+.*?[\']',
+		  $LEADIN . qr'echo\s+(?:-[^e\s]+\s+)?\'[^\']*(\\[\\abcEfnrtv0])+.*?[\']',
 			# unsafe echo with backslashes
 		);
 		my @bashism_string_regexs = (
@@ -568,7 +568,7 @@ while (<SCRIPTS>) {
 		  qr'\$\{?PIPESTATUS\}?\b',      # $PIPESTATUS
 		  qr'\$\{?SHLVL\}?\b',	         # $SHLVL
 		  qr'<<<',                       # <<< here string
-		  $LEADIN . qr'echo\s+(?:-[^e]+\s+)?([\"])[^\"]*(\\[\\abcEfnrtv0])+.*?[\"]',
+		  $LEADIN . qr'echo\s+(?:-[^e\s]+\s+)?\"[^\"]*(\\[\\abcEfnrtv0])+.*?[\"]',
 			# unsafe echo with backslashes
 		);
 		my @bashism_regexs = (

-- 
Debian package checker


Reply to: