[SCM] Debian package checker branch, master, updated. ad09f133a313d2ba70328a6a5127edbea1d4b356
The following commit has been merged in the master branch:
commit ad09f133a313d2ba70328a6a5127edbea1d4b356
Author: Adam D. Barratt <adam@adam-barratt.org.uk>
Date: Thu Jul 3 23:10:23 2008 +0100
Check for embedded copies of Javascript libraries which are already packaged.
* checks/files{,.desc}:
+ [ADB] Warn if the package contains embedded copies of separately
packaged Javascript libraries. Patch by Chris Lamb. (Closes: #489191)
diff --git a/checks/files b/checks/files
index e682b6d..4a177c7 100644
--- a/checks/files
+++ b/checks/files
@@ -645,6 +645,17 @@ while (<IN>) {
tag "macos-resource-fork-file-in-package", "$file";
}
+ # ---------------- embedded Javascript libraries
+ if ($file =~ m,/(mochikit|
+ jquery(\.(min|lite|pack))?|
+ prototype(-[\d\.]+)?|
+ scriptaculous|
+ fckeditor|
+ cropper(\.uncompressed)?
+ )\.js(\.gz)?$,ix) {
+ tag "embedded-javascript-library", "$file";
+ }
+
# ---------------- general: setuid/setgid files!
if ($perm =~ m/s/) {
my ($setuid, $setgid) = ("","");
diff --git a/checks/files.desc b/checks/files.desc
index e3dec03..536c504 100644
--- a/checks/files.desc
+++ b/checks/files.desc
@@ -758,3 +758,11 @@ Info: The user or group ID of the owner of the file is invalid. The
of the allowed, globally allocated IDs consists of the ranges 0-99,
64000-64999 and 65534.
Ref: policy 9.2
+
+Tag: embedded-javascript-library
+Type: warning
+Info: This package contains an embedded copy of the JQuery, Prototype,
+ Mochikit or "Cropper" JavaScript libraries that are now available in their
+ own packages. Please depend on the appropriate package and symlink the
+ library into the appropriate location.
+Ref: policy 4.13
diff --git a/debian/changelog b/debian/changelog
index 845c5f2..005c35e 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -15,6 +15,9 @@ lintian (1.24.2) unstable; urgency=low
non-obsolete alternatives specified and if the obsolete
package is not listed first. Issue an info tag for them
though. Patch by Adam D. Barratt. (Closes: #486145)
+ * checks/files{,.desc}:
+ + [ADB] Warn if the package contains embedded copies of separately
+ packaged Javascript libraries. Patch by Chris Lamb. (Closes: #489191)
* checks/infofiles{,.desc}:
+ [ADB] Warn if the package's postinst installs info directory entries
but the prerm doesn't remove them. (Closes: #182512)
diff --git a/testset/filenames/debian/rules b/testset/filenames/debian/rules
index 8a00ae0..921637d 100755
--- a/testset/filenames/debian/rules
+++ b/testset/filenames/debian/rules
@@ -155,6 +155,17 @@ binary-indep:
install -d debian/tmp/usr/share/gnome/apps/System
touch debian/tmp/usr/share/gnome/apps/System/foo.desktop
+ install -d debian/tmp/usr/share/filenames
+ touch debian/tmp/usr/share/filenames/jquery.js
+ touch debian/tmp/usr/share/filenames/jquery.lite.js
+ touch debian/tmp/usr/share/filenames/jquery.min.js
+ touch debian/tmp/usr/share/filenames/jquery.pack.js
+ touch debian/tmp/usr/share/filenames/mochikit.js
+ touch debian/tmp/usr/share/filenames/prototype-1.2.3.4.js
+ touch debian/tmp/usr/share/filenames/prototype.js
+ touch debian/tmp/usr/share/filenames/prototype.js.gz
+ touch debian/tmp/usr/share/filenames/scriptaculous.js
+
ln -s '../filenames/doc/version6.txt.gz' debian/tmp/usr/share/doc/filenames/version.txt.gz
ln -s ../../share/symlink debian/tmp/usr/lib/filenames/symlink1ok
ln -s ../../../etc/symlink debian/tmp/usr/lib/filenames/symlink1wrong
diff --git a/testset/tags.filenames b/testset/tags.filenames
index f1ae5f1..ce3b7f0 100644
--- a/testset/tags.filenames
+++ b/testset/tags.filenames
@@ -60,6 +60,15 @@ W: filenames: binary-without-manpage usr/bin/X11/testxbin
W: filenames: binary-without-manpage usr/bin/mh/read
W: filenames: debian-news-file-not-compressed usr/share/doc/filenames/NEWS.Debian
W: filenames: desktop-file-in-wrong-dir usr/share/gnome/apps/System/foo.desktop
+W: filenames: embedded-javascript-library usr/share/filenames/jquery.js
+W: filenames: embedded-javascript-library usr/share/filenames/jquery.lite.js
+W: filenames: embedded-javascript-library usr/share/filenames/jquery.min.js
+W: filenames: embedded-javascript-library usr/share/filenames/jquery.pack.js
+W: filenames: embedded-javascript-library usr/share/filenames/mochikit.js
+W: filenames: embedded-javascript-library usr/share/filenames/prototype-1.2.3.4.js
+W: filenames: embedded-javascript-library usr/share/filenames/prototype.js
+W: filenames: embedded-javascript-library usr/share/filenames/prototype.js.gz
+W: filenames: embedded-javascript-library usr/share/filenames/scriptaculous.js
W: filenames: executable-not-elf-or-script ./usr/bin/bin/bad
W: filenames: executable-not-elf-or-script ./usr/bin/mh/read
W: filenames: extra-license-file usr/share/pixmaps/COPYING
--
Debian package checker
Reply to: